FS#71113 - [seamonkey] 2.53.7.1, does not build with nss 3.66

Attached to Project: Community Packages
Opened by Andreas Baumann (andreas_baumann) - Thursday, 03 June 2021, 10:01 GMT
Last edited by Andreas Radke (AndyRTR) - Thursday, 22 July 2021, 05:30 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Kyle Keen (keenerd)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

In file included from /build/seamonkey/src/seamonkey-2.53.7.1/obj-x86_64-pc-linux-gnu/dom/bindings/Unifie
dBindings8.cpp:302:
In file included from /build/seamonkey/src/seamonkey-2.53.7.1/obj-x86_64-pc-linux-gnu/dom/bindings/IDBDat
abaseBinding.cpp:16:
/build/seamonkey/src/seamonkey-2.53.7.1/obj-x86_64-pc-linux-gnu/dist/include/mozilla/dom/IDBTransaction.h
:62:5: error: expected identifier
CLEANUP,
^
/usr/include/nss/pk11hpke.h:12:5: note: expanded from macro 'CLEANUP'

Additional info:
* package version(s): 2.53.7.1
* link to upstream bug report, if any

https://bugzilla.mozilla.org/show_bug.cgi?id=1714311

Fixed it the fast way in:

https://git.archlinux32.org/packages/tree/community/seamonkey/seamonkey-2.53.7.1-CLEANUP.patch

Better or other ways to fix it:
* include pk11hpke.h and undefine CLEANUP, use the header file only in a small file in seamonkey
(I doubt the indexdb needs nss)
* private header file for global macros like CLEANUP in pk11hpke.h (but this has to be discussed
with the nss guys).

Steps to reproduce:
asp export community/seamonkey
cd seamonkey
staging-x86_64-build
This task depends upon

Closed by  Andreas Radke (AndyRTR)
Thursday, 22 July 2021, 05:30 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed seamonkey 2.53.8-1
Comment by loqs (loqs) - Thursday, 03 June 2021, 10:57 GMT
I believe firefox does not have the issue because of [1].
Edit:
I was able to get the commit to apply with a lot of manual adjustment. No advantage to this approach, I was just testing it if would work.

[1] https://github.com/mozilla/gecko-dev/commit/55a2f652bcdcd06d3dff96b27fd4c012259b8df8
   seamonkey-use-scoped-enums-in... (32.3 KiB)

Loading...