FS#70959 - [rubygems] package should provide operating_system.rb, not patch the code

Attached to Project: Arch Linux
Opened by Felipe Contreras (felipec) - Thursday, 20 May 2021, 19:08 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:26 GMT
Task Type General Gripe
Category Packages: Extra
Status Closed
Assigned To Anatol Pomozov (anatolik)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

rubygems provides a way for distributions override defaults, right now there's a patch to make install_extension_in_lib return false, but that's not the way to do it.

This code:

module Gem

def self.install_extension_in_lib
false
end

end

achieves the same thing when placed in /usr/lib/ruby/${rubyver}/rubygems/defaults/operating_system.rb.

The patch references Fedora's own operating_system.rb, which overrides install_extension_in_lib in precisely the same way.

https://src.fedoraproject.org/rpms/rubygems/raw/rawhide/f/operating_system.rb
This task depends upon

Closed by  Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:26 GMT
Reason for closing:  Moved
Additional comments about closing:  https://gitlab.archlinux.org/archlinux/p ackaging/packages/rubygems/issues/3
Comment by Felipe Contreras (felipec) - Friday, 21 May 2021, 08:22 GMT
Please note that  FS#70961  contains the more correct operating_system.rb that calls remove_method in order to remove warnings with `ruby -w`. Fedora does the same.
Comment by Buggy McBugFace (bugbot) - Tuesday, 08 August 2023, 19:11 GMT
This is an automated comment as this bug is open for more then 2 years. Please reply if you still experience this bug otherwise this issue will be closed after 1 month.
Comment by Alexandre ZANNI (noraj) - Monday, 04 September 2023, 10:45 GMT
The patch https://gitlab.archlinux.org/archlinux/packaging/packages/rubygems/-/blob/main/rubygems_stop_so_duplication.patch?ref_type=heads was to avoid .so duplication but it is actually causing loading error (see https://github.com/boazsegev/iodine/issues/148#issuecomment-1705021468) because when required, only `lib/` seems to be taken into account and not `ext/`. Could we remove this patch?
Comment by Felipe Contreras (felipec) - Tuesday, 05 September 2023, 16:38 GMT
Fedora does set this, and I've seen they are the distribution that has spent the most effort trying to solve rubygems issues. It would be interesting to know their opinion on why that makes sense.

Loading...