FS#70848 - [cri-o] no crio.conf content starting with 1.21.0

Attached to Project: Community Packages
Opened by Omar Pakker (Omar007) - Thursday, 13 May 2021, 23:29 GMT
Last edited by Morten Linderud (Foxboron) - Tuesday, 17 August 2021, 12:11 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To David Runge (dvzrv)
Christian Rebischke (Shibumi)
Morten Linderud (Foxboron)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Starting with the 1.21.0 package, the shipped configuration file is completely empty.

Looks like this might be an upstream issue and not an Arch packaging specific one[1] but checking the previous releases, some fields are set explicitly and not commented out so I'm not entirely sure which are and which aren't actually matching the cri-o defaults.

Personally I've just kept the old/existing config in place in the mean time.

[1] https://github.com/cri-o/cri-o/issues/4770
This task depends upon

Closed by  Morten Linderud (Foxboron)
Tuesday, 17 August 2021, 12:11 GMT
Reason for closing:  Not a bug
Comment by Omar Pakker (Omar007) - Thursday, 29 July 2021, 14:19 GMT
I took some time to go through the config recently and compared it to the crio documentation and their defaults. There are a few more differences but the only one that matters for Arch Linux is the [crio.network] segment.

My suggestion would be to update the package to provide a drop-in configuration file for this Arch specific deviation;

```
$ cat /etc/crio/crio.conf.d/00-default.conf
[crio.network]
plugin_dirs = [
"/usr/lib/cni/",
]
```

The other differences I've spotted do not result in a net difference on Arch Linux VS. their default value; e.g. some (but not all) properties are set to use '/run/...' instead of the default '/var/run/...' but the latter is symlinked to the first on Arch so the net result for both is files in '/run'.

EDIT: that said, I just noticed the cni-plugins package actually has said files stored/duplicated on both that location as well as the default specified by crio so that might not actually be needed at all either.
In which case, this can probably just be closed.
Comment by Morten Linderud (Foxboron) - Thursday, 29 July 2021, 14:29 GMT
That seems like a fine solution for me. A little bit annoying that we can't have `/usr/share/crio/crio.conf.d` or something similar, but can probably add the /etc files into the backup array for good measure as well.
Comment by Omar Pakker (Omar007) - Thursday, 29 July 2021, 14:47 GMT
Ah I may have crossed you with my edit; that might not even be needed, looking at what that config property needs and references.

In short; the cni-plugins package has said files duplicated at that customized location as well as at the CRI-O default location so either value would actually work on Arch at the moment. As such, this can probably just be closed; no actual config is needed.
(one just needs to make sure that when customizing locations yourself, you use the same one everywhere. And most (if not all) default and install themselves to the other one anyway; /opt/cni/bin)

Loading...