FS#70828 - [vdirsyncer] python-click 8.0.0-1 breaks package

Attached to Project: Community Packages
Opened by Moabit (Moabit) - Wednesday, 12 May 2021, 23:14 GMT
Last edited by Levente Polyak (anthraxx) - Thursday, 13 May 2021, 10:37 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To David Runge (dvzrv)
Daniel M. Capella (polyzen)
Architecture All
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

Description:
I upgraded python-click (7.1.2-4 -> 8.0.0-1) this morning. vdirsyncer no longer works.

Additional info:
* vdirsyncer 0.16.8-7
* python-click 8.0.0-1

Steps to reproduce:
```
$ vdirsyncer -vdebug sync
debug: Using 1 maximal workers.
error: Unknown error occurred: unmatched ')' (<string>, line 1)
error: Use `-vdebug` to see the full traceback.
debug: File "/usr/lib/python3.9/site-packages/vdirsyncer/cli/__init__.py", line 30, in inner
debug: f(*a, **kw)
debug: File "/usr/lib/python3.9/site-packages/vdirsyncer/cli/__init__.py", line 145, in sync
debug: with wq.join():
debug: File "/usr/lib/python3.9/contextlib.py", line 117, in __enter__
debug: return next(self.gen)
debug: File "/usr/lib/python3.9/site-packages/vdirsyncer/cli/utils.py", line 364, in join
debug: with ui_worker.patch_click():
debug: File "/usr/lib/python3.9/contextlib.py", line 117, in __enter__
debug: return next(self.gen)
debug: File "/usr/lib/python3.9/site-packages/click_threading/__init__.py", line 144, in patch_click
debug: with patch_ui_functions(wrapper):
debug: File "/usr/lib/python3.9/contextlib.py", line 117, in __enter__
debug: return next(self.gen)
debug: File "/usr/lib/python3.9/site-packages/click_threading/monkey.py", line 50, in patch_ui_functions
debug: stub_f = eval('lambda {s}: {n}._real_click_fn({a})'
```

Upstream bug report: https://github.com/pimutils/vdirsyncer/issues/887
This task depends upon

Closed by  Levente Polyak (anthraxx)
Thursday, 13 May 2021, 10:37 GMT
Reason for closing:  Fixed
Additional comments about closing:  python-click-threading 0.4.4-10
Comment by Jim Turner (jturner314) - Thursday, 13 May 2021, 00:33 GMT
The root cause is that python-click-threading 0.4.4-9 (which is one of the dependencies of vdirsyncer) is incompatible with python-click 8.0.0-1 due to the way it monkey patches python-click's functions. I've created a PR [1] with a minimal fix for python-click-threading. In the meantime, it may be worth marking python-click-threading as incompatible with python-click 8.0.0-1.

[1]: https://github.com/click-contrib/click-threading/pull/5

Loading...