FS#70602 - [picocom] don't use uucp lock, switch to flock

Attached to Project: Community Packages
Opened by tinywrkb (tinywrkb) - Monday, 26 April 2021, 22:10 GMT
Last edited by Sébastien Luttringer (seblu) - Friday, 30 July 2021, 08:51 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sébastien Luttringer (seblu)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

flock is already supported, uucp locks should've died with the analog modems, see some reasoning here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=734086
the suggested change drops the defined UUCP_LOCK_DIR that disabled flock, and then the tmpfiles.d config is not needed.

----

diff --git a/trunk/PKGBUILD b/trunk/PKGBUILD
index 3d3f1998..e91e82ac 100644
--- a/trunk/PKGBUILD
+++ b/trunk/PKGBUILD
@@ -3,7 +3,7 @@

pkgname=picocom
pkgver=3.1
-pkgrel=2
+pkgrel=3
pkgdesc='Minimal dumb-terminal emulation program, very much like minicom'
url='https://github.com/npat-efault/picocom'
license=('GPL2')
@@ -14,18 +14,13 @@ source=("git+https://github.com/npat-efault/picocom.git#tag=$pkgver")

build() {
cd $pkgname
- make UUCP_LOCK_DIR=/run/lock/picocom
+ make
}

package() {
cd $pkgname
install -D -m 755 picocom "$pkgdir/usr/bin/picocom"
install -D -m 644 picocom.1 "$pkgdir/usr/share/man/man1/picocom.1"
- # install tmpfiles for lock files
- # http://lists.freedesktop.org/archives/systemd-devel/2011-March/001823.html
- install -D -m 644 /dev/null "$pkgdir/usr/lib/tmpfiles.d/$pkgname.conf"
- echo "d /run/lock/$pkgname 0770 root uucp" \
- > "$pkgdir/usr/lib/tmpfiles.d/$pkgname.conf"
}

# vim:set ts=2 sw=2 et:
This task depends upon

Closed by  Sébastien Luttringer (seblu)
Friday, 30 July 2021, 08:51 GMT
Reason for closing:  Fixed
Additional comments about closing:  picocom-3.1-3

Loading...