FS#70573 - [xscreensaver] Build using gtkbuilder instead of glade

Attached to Project: Arch Linux
Opened by loqs (loqs) - Saturday, 24 April 2021, 14:24 GMT
Last edited by Levente Polyak (anthraxx) - Monday, 26 April 2021, 21:25 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Allan McRae (Allan)
Levente Polyak (anthraxx)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
Xscreensaver now supports building using gtkbuilder as well as glade. It is still gtk2 based.
Attached PKGBUILD.diff replaces libglade with gtk2 in depends.
It also changes the unrecognized option --with-x-app-defaults to --with-app-defaults.

Not changed
/usr/bin/xscreensaver is now installed 0755 so the chmod had no effect.
There are two other executables that run setuid / setgid:
xscreensaver W: File (usr/lib/xscreensaver/sonar) is setuid or setgid.
xscreensaver W: File (usr/lib/xscreensaver/xscreensaver-auth) is setuid or setgid.
the latter can be disabled with --without-setuid-hacks and rely on the net.ipv4.ping_group_range sysctl to allow PING.

Additional info:
* xscreensaver 6.00-1
   PKGBUILD.diff (0.9 KiB)
This task depends upon

Closed by  Levente Polyak (anthraxx)
Monday, 26 April 2021, 21:25 GMT
Reason for closing:  Implemented
Additional comments about closing:  6.00-2
Comment by Eli Schwartz (eschwartz) - Sunday, 25 April 2021, 15:23 GMT
The libglade dependency is presumably just dead weight at this point. ISTR looking at the source changes and libglade is not "as well as" but dropped entirely...

I did message anthraxx about this change but someone else handled the update I guess without realizing libglade can be dropped.
Comment by loqs (loqs) - Monday, 26 April 2021, 03:11 GMT
After lablgtk2 and xscreensaver are rebuilt without libglade I presume the package can then be dropped.
Comment by Allan McRae (Allan) - Monday, 26 April 2021, 03:30 GMT
I'm happy to rebuild using the patch but I don't know enough about the package to deal with setuid/setguid stuff.
Comment by loqs (loqs) - Monday, 26 April 2021, 19:08 GMT
@Allan do you want to apply the libglade related patch and I can open a separate FS for the permissions stuff?
Comment by Levente Polyak (anthraxx) - Monday, 26 April 2021, 20:21 GMT
@logq: I suspect you mean former instead of latter? --without-setuid-hacks works for sonar suid, xscreensaver-auth is expected to be suid as its the new split privileged component that sets oomd stuff etc. as far as i see, having suid on xscreensaver-auth does not introduce any issues like the sonar caps problem oss-security is currently discussing.
Comment by loqs (loqs) - Monday, 26 April 2021, 20:29 GMT
@anthraxx yes I meant the former instead of latter.

Loading...