FS#70396 - [bemenu] should not depend on wlroots
Attached to Project:
Community Packages
Opened by Simon Ser (emersion) - Saturday, 10 April 2021, 10:45 GMT
Last edited by Ivy Foster (escondida) - Tuesday, 04 May 2021, 15:30 GMT
Opened by Simon Ser (emersion) - Saturday, 10 April 2021, 10:45 GMT
Last edited by Ivy Foster (escondida) - Tuesday, 04 May 2021, 15:30 GMT
|
Details
bemenu doesn't depend on wlroots. wlroots is a library for
Wayland compositors. bemenu is a Wayland client.
|
This task depends upon
I don't think it's a good idea to document that a client requires a compositor feature by depending on a particular compositor library.
In any case, a build-time dependency doesn't make sense.
X11 clients don't depend on xorg-server. I don't see why Wayland clients would be different. Also this doesn't match the rest of the Arch Wayland packages like grim, slurp, swaybar, swaybg, swayidle, wf-recorder, xdg-desktop-portal-wlr and so on.
BTW, I'm the Wayland and Weston maintainer. Please trust me when I say this doesn't make sense.
If I rename bemenu-wlroots bemenu-wayland and remove the dependency, then I fully anticipate spurious bug reports: "tried it in <my favorite not-window-manager>, didn't work, broken package, plz fix".
I suppose I could add an optdepends: "wlroots-based not-window-manager: run it in one of these if you want the thing to actually function"...if I thought most people actually looked at pacman's output like they should. Would that be a satisfactory solution?
Don't pull a whole compositor library, which also comes with its own dependencies, just to mean that it may not work on all Wayland compositors.
Submit evidence
>*Some* non-wlroots-based compositors. Not all. *Which* not-window-manager you pick determines what programs you can run for some insane reason, which means that it's necessary to communicate the flavor that it's compatible with.
Why are you even maintaining this package if you're just going to flame Wayland? Let someone else do it.
This package should not depend on wlroots. It should not optdepend on wlroots. It should not mention wlroots at all. This is a statement of fact, delivered to you by the experts.
Am I mistaken?
Optdepends is not a suitable location for adding virtual provides that don't exist anywhere and are solely there for sending messages to the user. It is a suitable location for adding a valid dependency linkage to another package or virtual package that actually exists and can be resolved by a machine, alongside a human readable description.
A suitable possibility would be:
optdepends=('wlroots: compositor that actually supports bemenu')
Or adding a special provides entry to each compositor that implements wlr-layer-shell and then depending on 'wlr-layer-shell-implementation' or idk something like that.
"Warning: many wayland composite don't support wlr-layer-shell, thus bemenu' won't work. Try a wlroots based one, or mir or kwin, as they are known to work"
A provides entry seems over-engineered, and won't accommodate for all cases (e.g. running via waypipe).
Please keep thinly veiled authority arguments, bad faiths arguments and other unconstructive nonesense out of the bugtracker.
Thank you.
eschwartz and emerson, I'll change it and add a post_install message later today.
>*Which* not-window-manager you pick determines what programs you can run for some insane reason, which means that it's necessary to communicate the flavor that it's compatible with.
This is embarassingly bad form from Arch here. This package is wrong, and needs to be fixed. This is not a thinly vieled critism, but an explicit critism: this is a bad look for Arch. What's unconstructive is a Linux distro ignoring the advice of and picking fights with upstream.
I agree it is over-engineered and flaky.
The only one picking fights is you.
In-case it's not obvious.
>Submit evidence
Is not an advice.
>Why are you even maintaining this package if you're just going to flame Wayland? Let someone else do it.
Is not an advice, and frankly rude. You know just as well as me that is rude towards people that dedicate their own free time to contribute.
>This package should not depend on wlroots. It should not optdepend on wlroots. It should not mention wlroots at all.
Is an advice, but could be worded better.
>This is a statement of fact, delivered to you by the experts.
Is not an advice either. 'ab auctoritate' - I don't need to tell you how this works.
I shouldn't need to tell you this Drew, people have told you plenty of times.
Edit: accidentally a word
emersion, I want to be clear that I absolutely respect your work and advice. Any rudeness arose exclusively from frustration, and so for any rudeness on my part, I'm sorry once again.
Closing as implemented.