FS#70389 - [arch-signoff] stack trace when signed-off package is not installed locally

Attached to Project: Arch Linux
Opened by Geert Hendrickx (ghen) - Friday, 09 April 2021, 15:13 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:16 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Jelle van der Waa (jelly)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

arch-signoff throws the following stacktrace on attempt to signoff a package not installed on the local machine.

$ signoff -s grub
Traceback (most recent call last):
File "/usr/bin/signoff", line 33, in <module>
sys.exit(load_entry_point('arch-signoff==0.5.1', 'console_scripts', 'signoff')())
File "/usr/lib/python3.9/site-packages/click/core.py", line 829, in __call__
return self.main(*args, **kwargs)
File "/usr/lib/python3.9/site-packages/click/core.py", line 782, in main
rv = self.invoke(ctx)
File "/usr/lib/python3.9/site-packages/click/core.py", line 1066, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/lib/python3.9/site-packages/click/core.py", line 610, in invoke
return callback(*args, **kwargs)
File "/usr/lib/python3.9/site-packages/signoff/__init__.py", line 402, in main
warn_if_outdated(signoff_pkg, local_pkg, colorize)
File "/usr/lib/python3.9/site-packages/signoff/__init__.py", line 278, in warn_if_outdated
if local_pkg.version != signoff_pkg["version"]:
AttributeError: 'NoneType' object has no attribute 'version'


(my primary machine is UEFI and does not have grub, but I validated the package on another machine)

I would expect this to work when adding -u (uninstalled), but it still throws the same stack trace.


Additional info:
* package version(s)
arch-signoff 0.5.1-2
This task depends upon

Closed by  Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:16 GMT
Reason for closing:  Moved
Additional comments about closing:  https://gitlab.archlinux.org/archlinux/p ackaging/packages/arch-signoff/issues/1
Comment by Jelle van der Waa (jelly) - Thursday, 15 April 2021, 21:39 GMT
One case is fixed in https://gitlab.archlinux.org/archlinux/arch-signoff/-/commit/94aacc0a7f1a80d41b3785b53673aaba40417872
Comment by Geert Hendrickx (ghen) - Saturday, 17 April 2021, 19:28 GMT
Can you make it possible to still signoff a package with -u ?
Comment by Jelle van der Waa (jelly) - Monday, 26 April 2021, 11:45 GMT
That's not as easy to implement nicely, so I'll have to think about it more.
Comment by Buggy McBugFace (bugbot) - Tuesday, 08 August 2023, 19:11 GMT
This is an automated comment as this bug is open for more then 2 years. Please reply if you still experience this bug otherwise this issue will be closed after 1 month.

Loading...