FS#70232 - [grub] missing & misleading configuration options

Attached to Project: Arch Linux
Opened by Nathan M. Swan (personak) - Tuesday, 30 March 2021, 13:30 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:14 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Christian Hesse (eworm)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

GRUB has four special variables for its UI colors: color_normal, color_highlight, menu_color_normal, and menu_color_highlight [0]. The arch package has a patch to grub-mkconfig which enables setting the menu_color_* variables from /etc/default/grub [1]. The grub-mkconfig variable names are misleading, and the regular color_* variables should be added.

Currently, /etc/grub.d/00_header contains this:

set menu_color_normal=$GRUB_COLOR_NORMAL
set menu_color_highlight=$GRUB_COLOR_HIGHLIGHT

When it seems more clear and complete to have this:

set color_normal=$GRUB_COLOR_NORMAL
set color_highlight=$GRUB_COLOR_HIGHLIGHT
set menu_color_normal=$GRUB_MENU_COLOR_NORMAL
set menu_color_highlight=$GRUB_MENU_COLOR_HIGHLIGHT

This is what was suggested in the email thread cited as a source for the patch [2], and in the debian patch the arch patch seems to be based on [3].

I haven't found any reason for only setting the menu variables while using non-MENU names, so I assume this was a mistake.

Additional info:
* package version(s)
2:2.04-10 and older

[0] https://www.gnu.org/software/grub/manual/grub/html_node/Special-environment-variables.html#Special-environment-variables
[1] https://github.com/archlinux/svntogit-packages/blob/packages/grub/trunk/0001-00_header-add-GRUB_COLOR_-variables.patch
[2] http://lists.gnu.org/archive/html/grub-devel/2012-02/msg00021.html
[3] https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=608283;filename=05_debian_theme_improvements.patch;msg=80
This task depends upon

Closed by  Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:14 GMT
Reason for closing:  Moved
Additional comments about closing:  https://gitlab.archlinux.org/archlinux/p ackaging/packages/grub/issues/4
Comment by Christian Hesse (eworm) - Tuesday, 30 March 2021, 18:53 GMT
I do not think changing this is a good idea... It has been this way since we switched to grub 2.x in 2012...
https://github.com/archlinux/svntogit-packages/commit/d5f3fa24fa266977ed850fe9b2d0fe5f10112f90
Comment by Buggy McBugFace (bugbot) - Tuesday, 08 August 2023, 19:11 GMT
This is an automated comment as this bug is open for more then 2 years. Please reply if you still experience this bug otherwise this issue will be closed after 1 month.

Loading...