FS#70029 - [molecule] missing makedepend on python-toml

Attached to Project: Community Packages
Opened by Kevin Mihelich (kmihelich) - Wednesday, 17 March 2021, 02:00 GMT
Last edited by David Runge (dvzrv) - Friday, 26 March 2021, 17:36 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To David Runge (dvzrv)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description: Checkdepends are being used as makedepends. When building without checks, the package fails to build. Missing a makedepend on python-toml.


Additional info:
* package version: 3.2.4-1
* log:
==> Starting build()...
/usr/lib/python3.9/site-packages/setuptools/dist.py:634: UserWarning: Usage of dash-separated 'max-line-length' will not be supported in future versions. Please use the underscore name 'max_line_length' instead
warnings.warn(
/usr/lib/python3.9/site-packages/setuptools/dist.py:634: UserWarning: Usage of dash-separated 'per-file-ignores' will not be supported in future versions. Please use the underscore name 'per_file_ignores' instead
warnings.warn(
WARNING: The wheel package is not available.
/usr/bin/python: No module named pip
Traceback (most recent call last):
File "/usr/lib/python3.9/site-packages/setuptools/installer.py", line 75, in fetch_build_egg
subprocess.check_call(cmd)
File "/usr/lib/python3.9/subprocess.py", line 373, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/usr/bin/python', '-m', 'pip', '--disable-pip-version-check', 'wheel', '--no-deps', '-w', '/tmp/tmpibik153s', '--quiet', 'toml']' returned non-zero exit status 1.

Steps to reproduce: Build in a clean chroot passing --nocheck to makepkg
This task depends upon

Closed by  David Runge (dvzrv)
Friday, 26 March 2021, 17:36 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed with molecule 3.3.0-1
Comment by Amin Vakil (aminvakil) - Wednesday, 17 March 2021, 13:45 GMT
Isn't this related to using scm_version and if that gets deleted wouldn't this be solved?
https://github.com/ansible-community/molecule/blob/bcb4cad371dd7a7dcc5cfc51b7496f46e801b552/setup.py#L36

Like the patch used in ansible-lint package: https://github.com/archlinux/svntogit-community/tree/packages/ansible-lint/trunk
Comment by Eli Schwartz (eschwartz) - Wednesday, 17 March 2021, 14:13 GMT
I'm very confused by that patch as it seems pretty wrong. Why not just depend on setuptools-scm and setuptools-scm-git-archive???
Comment by David Runge (dvzrv) - Friday, 26 March 2021, 17:35 GMT
@kmihelich: Thanks for the report. I will fix it in the next update.

Loading...