FS#69961 - [gitlab-runner] Upstream suggests service modification

Attached to Project: Community Packages
Opened by Caleb Maclennan (alerque) - Friday, 12 March 2021, 14:06 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Saturday, 13 March 2021, 00:09 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sven-Hendrik Haase (Svenstaro)
Anatol Pomozov (anatolik)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The gitlab-runner process handles singnals in a kind of orthodox way.

The upstream "best practices" page here: https://docs.gitlab.com/runner/best_practice/index.html
...suggests adding `KillSignal=SIGQUIT` plus a timeout to give it a chance to do a clean shutdown
in the event the service is stopped.
This task depends upon

Closed by  Sven-Hendrik Haase (Svenstaro)
Saturday, 13 March 2021, 00:09 GMT
Reason for closing:  Won't fix
Comment by Sven-Hendrik Haase (Svenstaro) - Saturday, 13 March 2021, 00:08 GMT
Upstream does suggest this but then again they also suggest to add this as an override in /etc/systemd/system/gitlab-runner.service.d/kill.conf. I'm going to keep the installed file as generated by upstream. People can apply upstream overrides as they see fit.

Loading...