FS#69834 - [python-keyring] missing makedepend on python-toml

Attached to Project: Community Packages
Opened by Kevin Mihelich (kmihelich) - Sunday, 28 February 2021, 22:03 GMT
Last edited by David Runge (dvzrv) - Friday, 09 September 2022, 15:10 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Filipe Laíns (FFY00)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description: Checkdepends are being used as makedepends. When building without checks, the package fails to build. Missing a makedepend on python-pip.


Additional info:
* package version: 22.3.0-1
* log:
==> Starting build()...
WARNING: The wheel package is not available.
/usr/bin/python: No module named pip
Traceback (most recent call last):
File "/usr/lib/python3.9/site-packages/setuptools/installer.py", line 75, in fetch_build_egg
subprocess.check_call(cmd)
File "/usr/lib/python3.9/subprocess.py", line 373, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/usr/bin/python', '-m', 'pip', '--disable-pip-version-check', 'wheel', '--no-deps', '-w', '/tmp/tmpjwynj01d', '--quiet', 'toml']' returned non-zero exit status 1.

Steps to reproduce: Build in a clean chroot passing --nocheck to makepkg
This task depends upon

Closed by  David Runge (dvzrv)
Friday, 09 September 2022, 15:10 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed with python-keyring 23.9.0-1
Comment by Eli Schwartz (eschwartz) - Sunday, 28 February 2021, 22:08 GMT
What, no, absolutely not.

The missing makedepends is on the toml module. Since it is missing, pip then tries to download and install it over the network, which is totally not ok. The solution is NEVER to install pip and let it do network things.

Loading...