FS#69787 - [github-cli] Missing shell completion
Attached to Project:
Community Packages
Opened by Marcin Puc (Tranzystorek) - Thursday, 25 February 2021, 22:06 GMT
Last edited by Morten Linderud (Foxboron) - Saturday, 06 March 2021, 12:31 GMT
Opened by Marcin Puc (Tranzystorek) - Thursday, 25 February 2021, 22:06 GMT
Last edited by Morten Linderud (Foxboron) - Saturday, 06 March 2021, 12:31 GMT
|
Details
Description:
The newest 1.6.2 build of github-cli seems to have broken shell completion file instalation (there are no completion files in the package list, and the completion does not work) Additional info: * package version: 1.6.2 |
This task depends upon
Closed by Morten Linderud (Foxboron)
Saturday, 06 March 2021, 12:31 GMT
Reason for closing: Fixed
Additional comments about closing: Fixed with 1.7.0-2
Saturday, 06 March 2021, 12:31 GMT
Reason for closing: Fixed
Additional comments about closing: Fixed with 1.7.0-2
```diff
diff --git i/trunk/PKGBUILD w/trunk/PKGBUILD
index 1edaa7f8..9d9d083c 100644
--- i/trunk/PKGBUILD
+++ w/trunk/PKGBUILD
@@ -4,7 +4,7 @@
pkgname=github-cli
pkgver=1.6.2
-pkgrel=1
+pkgrel=2
pkgdesc="The GitHub CLI"
arch=("x86_64")
url="https://github.com/cli/cli"
@@ -32,9 +32,6 @@ build()
export GOFLAGS="-buildmode=pie -trimpath -mod=readonly -modcacherw -ldflags=-linkmode=external"
make GH_VERSION="v$pkgver" bin/gh manpages
- bin/gh completion -s bash | install -Dm644 /dev/stdin share/bash-completion/completions/gh
- bin/gh completion -s zsh | install -Dm644 /dev/stdin share/zsh/site-functions/_gh
- bin/gh completion -s fish | install -Dm644 /dev/stdin share/fish/vendor_completions.d/gh.fish
}
check(){
@@ -50,6 +47,12 @@ check()
package() {
cd "cli-$pkgver"
make DESTDIR="${pkgdir}" prefix="/usr" install
+ bin/gh completion -s bash | \
+ install -Dm644 /dev/stdin "$pkgdir/usr/share/bash-completion/completions/gh"
+ bin/gh completion -s zsh | \
+ install -Dm644 /dev/stdin "$pkgdir/usr/share/zsh/site-functions/_gh"
+ bin/gh completion -s fish | \
+ install -Dm644 /dev/stdin "$pkgdir/usr/share/fish/vendor_completions.d/gh.fish"
install -Dm644 "LICENSE" "$pkgdir/usr/share/licenses/$pkgname/LICENSE"
install -Dm644 "README.md" "$pkgdir/usr/share/doc/$pkgname/README.md"
}
```
https://github.com/archlinux/svntogit-community/commit/98eb8168853b425878bceb5d73f9307c0b1e311c#diff-37538beb61ff63edebbf735dfcf39e5d732f49183d6beb097169d971875ca422L42
Will push a fix later today