FS#69780 - [nginx] Vim syntax file uses `hi link` instead of `hi def link`
Attached to Project:
Arch Linux
Opened by Chris Morgan (ChrisMorgan) - Thursday, 25 February 2021, 12:21 GMT
Last edited by Giancarlo Razzolini (grazzolini) - Tuesday, 20 April 2021, 16:45 GMT
Opened by Chris Morgan (ChrisMorgan) - Thursday, 25 February 2021, 12:21 GMT
Last edited by Giancarlo Razzolini (grazzolini) - Tuesday, 20 April 2021, 16:45 GMT
|
Details
Package: nginx 1.18.0-2
File: /usr/share/vim/vimfiles/syntax/nginx.vim Lines 2316–2336 start with `hi link`, but should start with `hi def link`. Otherwise I can’t set the highlighting in my colorscheme file, because the syntax file which is loaded after it clobbers it. See ':highlight-default' in the Vim help for more information and explanation. Attached is a patch that just adds `def` on each line that needs it. |
This task depends upon
Closed by Giancarlo Razzolini (grazzolini)
Tuesday, 20 April 2021, 16:45 GMT
Reason for closing: Upstream
Additional comments about closing: Upstream has fixed this bug
Tuesday, 20 April 2021, 16:45 GMT
Reason for closing: Upstream
Additional comments about closing: Upstream has fixed this bug
Comment by
Giancarlo Razzolini (grazzolini) -
Thursday, 25 February 2021, 16:21 GMT
Comment by
Chris Morgan (ChrisMorgan) -
Thursday, 25 February 2021, 16:25 GMT
Comment by
Giancarlo Razzolini (grazzolini) -
Thursday, 25 February 2021, 16:57 GMT
Comment by
Chris Morgan (ChrisMorgan) -
Thursday, 25 February 2021, 16:58 GMT
That file comes from upstream. I think this would be better filled
as a bug against upstream.
Ah hah, found it at
http://hg.nginx.org/nginx/file/tip/contrib/vim/syntax/nginx.vim. Sorry, for some bizarre reason I just assumed this would be
Arch-specific rather than having come from nginx. I’ll figure out
how to file it upstream.
No problem. You can add the upstream bug here too, and keep this
open.
I filed it at
https://trac.nginx.org/nginx/ticket/2141.