FS#69705 - [gtk3] Regression in XCompose handling

Attached to Project: Arch Linux
Opened by Oleksandr Natalenko (post-factum) - Friday, 19 February 2021, 13:10 GMT
Last edited by Jan Alexander Steffens (heftig) - Saturday, 20 February 2021, 17:02 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Jan Alexander Steffens (heftig)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 3
Private No

Details

Description:

3.24.25 broke comments in the XCompose file. Recent commits [1] fix that, so please consider backporting those.

[1] https://gitlab.gnome.org/GNOME/gtk/-/commits/gtk-3-24/gtk/gtkcomposetable.c

Additional info:
* package version(s)

gtk3-3.24.25-1

* config and/or log files etc.

Trailing "# comment" in the XCompose file breaks parses. See [2].

[2] https://gitlab.gnome.org/GNOME/gtk/-/issues/3664

* link to upstream bug report, if any

See above.

Steps to reproduce:


Just update to the latest gtk3, and if your XCompose file has trailing comments, the parser will bark at you in the console, and compose keys won't work.
This task depends upon

Closed by  Jan Alexander Steffens (heftig)
Saturday, 20 February 2021, 17:02 GMT
Reason for closing:  Fixed
Additional comments about closing:  gtk3 3.24.25-2
Comment by the second derivative (deltasquared) - Friday, 19 February 2021, 13:39 GMT
Was talking to post-factum about this in #archlinux earlier.
A minimal XCompose test line that should normally work (and is unlikely to be in the default compose list) is e.g.
<Multi_key> <N> <slash> : "ℕ"

Any end of line comment, such as e.g. # wat, will, for reference and bug searchability, cause potentially a lot of warnings of this form from most gtk3 applications (gnome-terminal-server simply being where I noticed it first), and the offending compose entries ignored:
(gnome-terminal-server:35797): Gtk-WARNING **: 13:28:38.628: Need to double-quote the value: "ℕ" # wat: <Multi_key> <N> <slash> : "ℕ" # wat

Loading...