FS#69694 - [fwupd] broken EFI binary in 1.5.6-1

Attached to Project: Community Packages
Opened by Toke Høiland-Jørgensen (tohojo) - Thursday, 18 February 2021, 15:25 GMT
Last edited by Bruno Pagani (ArchangeGabriel) - Wednesday, 21 July 2021, 13:49 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Bruno Pagani (ArchangeGabriel)
Filipe Laíns (FFY00)
Architecture x86_64
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
The EFI binary shipped with the 1.5.6-1 version of fwupd is broken on my system. Trying to launch it from the system firmware just fails, and loading it from systemd-boot or an efi shell says "unsupported file". The file size is also significantly smaller (44k vs 64k) than in the previous 1.5.5 version of the package (downgrading to that fixed the issue).
This task depends upon

Closed by  Bruno Pagani (ArchangeGabriel)
Wednesday, 21 July 2021, 13:49 GMT
Reason for closing:  Upstream
Additional comments about closing:  Fixed upstream in 1.5.7, and we are now at 1.6.1.
Comment by Adrian (adrian5) - Friday, 19 February 2021, 13:40 GMT
Toke, the file in question is `/usr/bin/fwupdate`, yes? On my system it's 67,624 byte for the 1.5.6-1 package.
Comment by Morten Linderud (Foxboron) - Friday, 19 February 2021, 13:50 GMT
I think this is related to the inclusion of SBAT in the EFI binary. Can you try rebuild the package without the sbat stuff (and remove supported_build) and see if it solves it?
Comment by Toke Høiland-Jørgensen (tohojo) - Friday, 19 February 2021, 14:28 GMT
@Adrian, no I'm talking about the efi binary in /usr/lib/fwupd/efi/fwupdx64.efi

@Morten, I tried recompiling without the SBAT args. That still gets me an EFI binary of 44k, but it does appear to be executing. I.e., I don't get the "unsupported file" error from systemd-boot when I select the firmware updater. However, it doesn't really appear to work correctly either: I just get a black screen that appears to hang. Whereas if I downgrade to 1.5.5, I get a "no update file found, called in error?" message when I execute the EFI binary...
Comment by Morten Linderud (Foxboron) - Friday, 19 February 2021, 14:32 GMT
This is an upstream fwupd bug fixed by https://github.com/fwupd/fwupd/pull/2902
Comment by Filipe Laíns (FFY00) - Friday, 19 February 2021, 15:13 GMT
I pushed fwupd 1.5.6-2, which backports that patch. Can you confirm this fixes the issue?
Comment by Toke Høiland-Jørgensen (tohojo) - Friday, 19 February 2021, 16:17 GMT
1.5.6-2 brought me back to "unsupported file". But this time recompiling without the SBAT stuff in configure *did* fix things... So, erm, partial success? :)
Comment by Filipe Laíns (FFY00) - Friday, 19 February 2021, 16:18 GMT
Would you mind opening an issue in the upstream?
Comment by Toke Høiland-Jørgensen (tohojo) - Friday, 19 February 2021, 16:33 GMT
Sure: https://github.com/fwupd/fwupd/issues/2910

Loading...