FS#69558 - [shorewall] Wrong StandardOutput parameter in service file

Attached to Project: Community Packages
Opened by Ouack Ouack (B3l3tte) - Saturday, 06 February 2021, 11:35 GMT
Last edited by Evangelos Foutras (foutrelis) - Tuesday, 12 April 2022, 03:44 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Evangelos Foutras (foutrelis)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

I got a warning from systemd each time shorewall starts :

févr. 06 11:58:33 Belette-PC systemd[1]: /usr/lib/systemd/system/shorewall.service:16: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.

Additional info:
Versions :
* local/shorewall 5.2.8-1
* local/shorewall-core 5.2.8-1

Service file (/usr/lib/systemd/system/shorewall.service) :
#
# The Shoreline Firewall (Shorewall) Packet Filtering Firewall
#
# Copyright 2011 Jonathan Underwood <jonathan.underwood@gmail.com>
#
[Unit]
Description=Shorewall IPv4 firewall
Wants=network-online.target
After=network-online.target
Conflicts=iptables.service firewalld.service

[Service]
Type=oneshot
RemainAfterExit=yes
EnvironmentFile=-/etc/sysconfig/shorewall
StandardOutput=syslog
ExecStart=/usr/bin/shorewall $OPTIONS start $STARTOPTIONS
ExecStop=/usr/bin/shorewall $OPTIONS stop
ExecReload=/usr/bin/shorewall $OPTIONS reload $RELOADOPTIONS

[Install]
WantedBy=basic.target

* Shorewall logging config (LOGFILE=systemd):
###############################################################################
# L O G G I N G
###############################################################################

LOG_LEVEL=info
BLACKLIST_LOG_LEVEL=
INVALID_LOG_LEVEL=
LOG_BACKEND=
LOG_MARTIANS=Yes
LOG_VERBOSITY=2
LOG_ZONE=Both
LOGALLNEW=
LOGFILE=systemd
LOGFORMAT="%s %s "
LOGTAGONLY=No
LOGLIMIT="s:1/sec:10"
MACLIST_LOG_LEVEL="$LOG_LEVEL"
RELATED_LOG_LEVEL=
RPFILTER_LOG_LEVEL="$LOG_LEVEL"
SFILTER_LOG_LEVEL="$LOG_LEVEL"
SMURF_LOG_LEVEL="$LOG_LEVEL"
STARTUP_LOG=/var/log/shorewall-init.log
TCP_FLAGS_LOG_LEVEL="$LOG_LEVEL"
UNTRACKED_LOG_LEVEL=

I think the following settings should be used by default :
/etc/shorewall.conf :
LOGFILE=systemd
/etc/systemd/system/basic.target.wants/shorewall.service :
No StandardOutput setting

Maybe that would mean patching the example configurations in /usr/share/doc/shorewall/Samples/ as well ?

Documentation :
https://shorewall.org/manpages/shorewall.conf.html
https://man.archlinux.org/man/systemd.exec.5
This task depends upon

Closed by  Evangelos Foutras (foutrelis)
Tuesday, 12 April 2022, 03:44 GMT
Reason for closing:  None
Additional comments about closing:  Moved to the AUR as upstream development has stopped.
Comment by loqs (loqs) - Saturday, 06 February 2021, 17:14 GMT
@B3l3tte if you apply [1] does that resolve the issue?

[1] https://gitlab.com/shorewall/code/-/commit/ba87937f49010b873307240e3a6f22deac511d89
Comment by Ouack Ouack (B3l3tte) - Saturday, 06 February 2021, 18:09 GMT
Absolutely ! So it seems it will be corrected in the next release

Loading...