FS#69506 - [fwupd] remove modules-load.d config for msr as it's a built-in module

Attached to Project: Community Packages
Opened by tinywrkb (tinywrkb) - Tuesday, 02 February 2021, 13:06 GMT
Last edited by Filipe Laíns (FFY00) - Thursday, 06 May 2021, 13:09 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Bruno Pagani (ArchangeGabriel)
Filipe Laíns (FFY00)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I don't believe that having this error on every boot with the official Arch Linux kernel package is something we want to keep.

> systemd-modules-load: Failed to find module 'msr'

MSR is a built-in module, and this is true for the linux package, not for linux-lts, so maybe put this on hold until linux-lts will be bumped to 5.10.
For other kernels, I can add a section in the fwupd wiki page about loading the module, post this change.

diff --git a/trunk/PKGBUILD b/trunk/PKGBUILD
index 35e4abd9..21fe108e 100644
--- a/trunk/PKGBUILD
+++ b/trunk/PKGBUILD
@@ -53,4 +53,8 @@ package() {
rm -r "${pkgdir}"/usr/share/installed-tests/
mv "${pkgdir}"/usr/bin/{,fwupd-}dbxtool
mv "${pkgdir}"/usr/share/man/man1/{,fwupd-}dbxtool.1
+
+ # remove msr module loading as it's a built-in kernel module
+ rm "${pkgdir}"/usr/lib/modules-load.d/fwupd-msr.conf
+ rmdir "${pkgdir}"/usr/lib/modules-load.d
}
This task depends upon

Closed by  Filipe Laíns (FFY00)
Thursday, 06 May 2021, 13:09 GMT
Reason for closing:  Fixed
Additional comments about closing:  fwupd 1.6.0-1
Comment by tinywrkb (tinywrkb) - Monday, 22 February 2021, 17:27 GMT
linux-lts is now on 5.10 and msr is a built-in module in all the official Arch Linux kernel packages (-zen included). Can we drop this, please?
I added information about msr module to the wiki page https://wiki.archlinux.org/index.php/Fwupd#MSR_plugin_is_failing_to_load
Comment by tinywrkb (tinywrkb) - Thursday, 06 May 2021, 12:02 GMT
@FFY00 Can this be fixed with the 1.6.0 update.
Comment by Filipe Laíns (FFY00) - Thursday, 06 May 2021, 13:08 GMT
Sorry for the delay, I have been a bit busy :/

Loading...