FS#69308 - [spotifyd] 0.2.25 completely broken (fix attached)

Attached to Project: Community Packages
Opened by Paulo Matias (thotypous_) - Wednesday, 13 January 2021, 02:34 GMT
Last edited by freswa (frederik) - Wednesday, 13 January 2021, 15:09 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To freswa (frederik)
Architecture All
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

There is a well-known bug in librespot-tremor (a crate on which spotifyd depends) that causes it to be completely broken when built with rustc >= 1.48.0.

Since spotifyd 0.2.25-1 was built with newer rustc than spotifyd 0.2.24-2, the package started to present the issue after being upgraded. The package is now completely unusable, as the daemon crashes when trying to play music.

The attached patch overrides librespot-tremor with a fixed version (pull request pending approval at upstream) so that it builds a correct binary with rustc 1.49.0 (the version currently shipped in Arch repos).

Additional info:
* package version(s) 0.2.25-1
* config and/or log files etc.

jan 12 20:36:49 pc spotifyd[224082]: Caught panic with message: attempted to zero-initialize type `librespot_tremor::tremor_sys::ov_callbacks`, which is invalid
jan 12 20:38:02 pc spotifyd[224082]: Caught panic with message: called `Result::unwrap()` on an `Err` value: "SendError(..)"
jan 12 20:38:02 pc spotifyd[224082]: Player thread panicked!
jan 12 20:38:02 pc systemd[490]: spotifyd.service: Main process exited, code=exited, status=101/n/a

* link to upstream bug report, if any: https://github.com/Spotifyd/spotifyd/issues/719

Steps to reproduce:
1. Start spotifyd
2. Try to play a music
3. Look at journalctl messages
This task depends upon

Closed by  freswa (frederik)
Wednesday, 13 January 2021, 15:09 GMT
Reason for closing:  Fixed
Additional comments about closing:  0.2.25-2

Loading...