Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/index.php/Reporting_Bug_Guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#69250 - [deluge] PeerID leaks development build info

Attached to Project: Arch Linux
Opened by binhex (binhex) - Friday, 08 January 2021, 10:28 GMT
Last edited by Andreas Radke (AndyRTR) - Wednesday, 21 April 2021, 10:37 GMT
Task Type Bug Report
Category Packages: Extra
Status Assigned
Assigned To Jan Alexander Steffens (heftig)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

Description:
Private torrent sites are detecting Deluge development version, even with the current hack in place to impersonate version 2.0.3 (user-agent-override.diff), thus Deluge is unable to connect to the tracker, and the tracker reports the fact that Deluge is a development build (see attached screenshot).

I believe it is to do with the PeerID leaking the fact that this is a development build (-DE204D-), is it possible for the PeerID to also be changed to appear to be a stable release?.

Additional info:
* package version(s): 2.0.4.dev38+g23a48dd01-3
* config and/or log files etc.: N/A
* link to upstream bug report, if any: N/A

Steps to reproduce: Install and run latest Deluge package from Arch Repository against a private torrent site and note that deluge will not be able to connect, due to deluge version being detected as development build, see attached screenshot.
This task depends upon

Comment by John (graysky) - Friday, 08 January 2021, 11:39 GMT
Have you made the change you proposed and tested that it solves the problem you identified?
Comment by binhex (binhex) - Friday, 08 January 2021, 17:25 GMT
I have attempted to fix the issue by editing the core.py, but this has not fixed the issue, so perhaps there are deeper code references to the development branch, for ref here is the script hack i came up with:-

```
sed -i -e "s~peer_id = substitute_chr(peer_id, 6, release_chr)~peer_id = \'--DE203s--\'\n release_chr = \'s\'~g" '/usr/lib/python3.8/site-packages/deluge/core/core.py'
```

This DOES change the peerid but somehow the private tracker is still detecting the connecting client as a dev version, so perhaps this task should be closed sadly, as it doesn't fix the issue.
Comment by John (graysky) - Friday, 08 January 2021, 19:12 GMT
My point was just that you're asking a packager to take an action without knowing if the action fixes the problem you identified. I suppose you could be asking a packager to solve the problem you identified but you'll likely get more eyes on it as a forum post or upstream issue report. In this case, I think upstream is no longer actively developing the software (at least this was true 3 months or so ago).
Comment by binhex (binhex) - Friday, 08 January 2021, 20:13 GMT
i see your point, the reason i posted here is that the package maintainer already has a hack in place (user-agent-override.diff) so i didnt think it a stretch to ask to fix up the peerid also. I was not aware upstream had stopped dev, this is an interesting update, in any case, feel free to close this task if you think this is invalid or the wrong place.
Comment by John (graysky) - Friday, 08 January 2021, 20:37 GMT
https://git.deluge-torrent.org/deluge/log/?h=develop

April of 2020 was the last commit to the dev branch. I switched over to qbittorrent and have been pretty happy although I am not a big torrent user.
Comment by Jan Alexander Steffens (heftig) - Wednesday, 21 April 2021, 10:53 GMT
Try 2.0.4.dev56+g2e466101f-1

Loading...