FS#69238 - network-manager-applet should not use libappindicator

Attached to Project: Arch Linux
Opened by Michael Wyraz (mwyraz) - Thursday, 07 January 2021, 10:06 GMT
Last edited by Balló György (City-busz) - Wednesday, 07 June 2023, 07:37 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Jan Alexander Steffens (heftig)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

libappindicator-gtk3 seems to be seriously broken (at least on xfce4). When nm-applet is launched with --indicator, the following issues occur:

* left and right mouse click opens the same menu (network list), it's not possible to open the context menu anymore
* the menu opens beneath the mouse cursor
* when the left mouse button is released, the menu action beneath the mouse cursor is executed (which is "edit network")
* as a result, clicking on the icon, the network editor opens

Even worse, with installing libappindicator-gtk3, other applications uses the lib (which otherwise use a different tray implementation). This includes blueman-applet as well as any electron app. On these applications, the left-mouse action is then replaced by the context menu which behaves as described above (in this case, a left click clioses the applications since the context menu action beneath the mouse is "exit")


Additional info:
* network-manager-applet-1.18.0-1, libappindicator-gtk3-12.10.0.r296-1

Steps to reproduce:

* install network-manager-applet on an xfce4 desktop
* start it with --indicator

How to fix this:

* Build network-manager-appler without libappindicator support (remove the 2 occurences of "libappindicator-gtk3" in the PKGBUILD, add "-D appindicator=false" to the arch-meson options)
* Maybe create a second package that contains mn-applet with indicator support for those who need it.
This task depends upon

Closed by  Balló György (City-busz)
Wednesday, 07 June 2023, 07:37 GMT
Reason for closing:  Upstream
Comment by Michael Wyraz (mwyraz) - Thursday, 07 January 2021, 13:41 GMT
I created an upstream bug: https://bugs.launchpad.net/bugs/1910521
Comment by Balló György (City-busz) - Wednesday, 07 June 2023, 07:37 GMT
> * left and right mouse click opens the same menu (network list), it's not possible to open the context menu anymore

It's a limitation of libappindicator. Appindicators can have only one menu, but you can still access all features.

> * the menu opens beneath the mouse cursor
> * when the left mouse button is released, the menu action beneath the mouse cursor is executed (which is "edit network")
> * as a result, clicking on the icon, the network editor opens

It sounds like an implementation issue in xfce4-panel StatusNotifier support. If it still happens, report it to the upstream developers: https://gitlab.xfce.org/xfce/xfce4-panel/-/issues

Some desktop environments don't support legacy XEmbed tray icons, so we have to keep indicator support for those users.

Loading...