Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#69179 - [lxc] cannot build without modifications to upstream files

Attached to Project: Community Packages
Opened by John (graysky) - Saturday, 02 January 2021, 13:53 GMT
Last edited by Jelle van der Waa (jelly) - Saturday, 02 January 2021, 21:10 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Currently, one cannot build this without modifying some upstream files. I believe a change occurred around 28-Dec (using packages from 27-Dec-2020 allows the current PKGBUILD to build successfully). In any case, the attached patch fixes the build issues.


Example failure without patch:
po -c -o mainloop.o mainloop.c &&\
mv -f $depbase.Tpo $depbase.Po
log.c:85:20: error: function declaration isn’t a prototype [-Werror=strict-prototypes]
85 | static const char *lxc_log_get_container_name()
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
log.c: In function ‘lxc_log_get_container_name’:
log.c:85:20: error: old-style function definition [-Werror=old-style-definition]
log.c: In function ‘lxc_log_options_no_override’:
log.c:817:13: error: old-style function definition [-Werror=old-style-definition]
817 | inline void lxc_log_options_no_override()
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
This task depends upon

Closed by  Jelle van der Waa (jelly)
Saturday, 02 January 2021, 21:10 GMT
Reason for closing:  Fixed
Additional comments about closing:  https://github.com/archlinux/svntogit-co mmunity/commit/13e4f6c6036bcc2ebdde1dfdd 50a2ac74094511b
Comment by Jelle van der Waa (jelly) - Saturday, 02 January 2021, 14:01 GMT
the patch should go upstream and we should just build with --with-noerror or whatever disables -Werror
Comment by John (graysky) - Saturday, 02 January 2021, 15:59 GMT
@jelly - I'd send them a PR but am unsure how to code it up without digging into it.
Comment by loqs (loqs) - Saturday, 02 January 2021, 16:29 GMT
--disable-werror disables -Werror
Comment by John (graysky) - Saturday, 02 January 2021, 20:42 GMT
@loqs - Good call. Adding that switch and retaining the single sed line in the PKGBUILD allows 1:4.0.5-1 to build. No need for the patch I included.

Loading...