FS#69146 - [vulkan-validation-layers] 1.2.162 introduced a new nested directory "usr/include/vulkan/vulkan/"

Attached to Project: Arch Linux
Opened by Pedro H. Lara Campos (PedroHLC) - Wednesday, 30 December 2020, 17:48 GMT
Last edited by Laurent Carlier (lordheavy) - Thursday, 31 December 2020, 06:16 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Laurent Carlier (lordheavy)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

We went from:
```
extra/vulkan-validation-layers 1.2.158-1 (vulkan-devel)
usr/include/vulkan/vk_layer_dispatch_table.h
```
to:
```
extra/vulkan-validation-layers 1.2.162-1 (vulkan-devel)
usr/include/vulkan/vulkan/vk_layer_dispatch_table.h
```

Additional info:
* 1.2.162 introduced, 1.2.158-1 was okay.
* Seems to have been rolled by an automatic version bump https://github.com/archlinux/svntogit-packages/commit/d653d101faa8b084f48734c621573d337acc45cc
* All changes upstream: https://github.com/KhronosGroup/Vulkan-ValidationLayers/compare/v1.2.158...v1.2.162

This change was made by a:
```
- install(FILES ${LAYER_UTIL_FILES} DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
+ install(FILES ${LAYER_UTIL_FILES} DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/vulkan)
```
in upstream's `layers/CMakeLists.txt` in commit `ddeed65b37f58f7ef2efaae92ea23ab99dbc6929`

Steps to reproduce:
Try to build anything depending on `vulkan-validation-layers` and it will fail...

Solution:
```
- -DCMAKE_INSTALL_INCLUDEDIR="/usr/include/vulkan/" \
+ -DCMAKE_INSTALL_INCLUDEDIR="/usr/include/" \
```
This task depends upon

Closed by  Laurent Carlier (lordheavy)
Thursday, 31 December 2020, 06:16 GMT
Reason for closing:  Fixed
Additional comments about closing:  vulkan-validation-layers-1.2.162-2
Comment by Eli Schwartz (eschwartz) - Wednesday, 30 December 2020, 19:39 GMT
$ checkpkg
usr/include/vulkan/cast_utils.h | usr/include/vulkan/vulkan/
usr/include/vulkan/hash_util.h | usr/include/vulkan/vulkan/cast_utils.h
usr/include/vulkan/hash_vk_types.h | usr/include/vulkan/vulkan/hash_util.h
usr/include/vulkan/vk_dispatch_table_helper.h | usr/include/vulkan/vulkan/hash_vk_types.h
usr/include/vulkan/vk_enum_string_helper.h | usr/include/vulkan/vulkan/vk_dispatch_table_helper.h
usr/include/vulkan/vk_extension_helper.h | usr/include/vulkan/vulkan/vk_enum_string_helper.h
usr/include/vulkan/vk_format_utils.cpp | usr/include/vulkan/vulkan/vk_extension_helper.h
usr/include/vulkan/vk_format_utils.h | usr/include/vulkan/vulkan/vk_format_utils.cpp
usr/include/vulkan/vk_layer_config.cpp | usr/include/vulkan/vulkan/vk_format_utils.h
usr/include/vulkan/vk_layer_config.h | usr/include/vulkan/vulkan/vk_layer_config.cpp
usr/include/vulkan/vk_layer_data.h | usr/include/vulkan/vulkan/vk_layer_config.h
usr/include/vulkan/vk_layer_dispatch_table.h | usr/include/vulkan/vulkan/vk_layer_data.h
usr/include/vulkan/vk_layer_extension_utils.cpp | usr/include/vulkan/vulkan/vk_layer_dispatch_table.h
usr/include/vulkan/vk_layer_extension_utils.h | usr/include/vulkan/vulkan/vk_layer_extension_utils.cpp
usr/include/vulkan/vk_layer_logging.h | usr/include/vulkan/vulkan/vk_layer_extension_utils.h
usr/include/vulkan/vk_layer_utils.cpp | usr/include/vulkan/vulkan/vk_layer_logging.h
usr/include/vulkan/vk_layer_utils.h | usr/include/vulkan/vulkan/vk_layer_utils.cpp
usr/include/vulkan/vk_loader_platform.h | usr/include/vulkan/vulkan/vk_layer_utils.h
usr/include/vulkan/vk_object_types.h | usr/include/vulkan/vulkan/vk_loader_platform.h
usr/include/vulkan/vk_safe_struct.cpp | usr/include/vulkan/vulkan/vk_object_types.h
usr/include/vulkan/vk_safe_struct.h | usr/include/vulkan/vulkan/vk_safe_struct.cpp
usr/include/vulkan/vk_typemap_helper.h | usr/include/vulkan/vulkan/vk_safe_struct.h
usr/include/vulkan/vk_validation_error_messages.h | usr/include/vulkan/vulkan/vk_typemap_helper.h
usr/include/vulkan/xxhash.c | usr/include/vulkan/vulkan/vk_validation_error_messages.h
usr/include/vulkan/xxhash.h | usr/include/vulkan/vulkan/xxhash.c
> usr/include/vulkan/vulkan/xxhash.h
> usr/share/doc/vulkan-validation-layers/portability_validation
==> No soname differences for vulkan-validation-layers.

This should be a red flag when building the new release. :(

Loading...