FS#68992 - waybar 0.9.4-4 breaks MPD display

Attached to Project: Community Packages
Opened by Aubergine (Aubergine) - Tuesday, 15 December 2020, 22:34 GMT
Last edited by Brett Cornwall (ainola) - Thursday, 24 December 2020, 06:26 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To David Runge (dvzrv)
Brett Cornwall (ainola)
Maxim Baz (maximbaz)
Architecture x86_64
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

Since update to 0.9.4-4 (and it's also the case for 0.9.4-5) I'm encountering two issues with the MPD module of waybar:
* the option format-disconnected seems to be ignored: I used to have an empty string and a special style; the special style is not displayed, and when I added a few chars to the string I could note that the string itself is ignored;
* the display seems fine when the server is running; however, if I kill the server, instead of going back to idle mode it keeps on showing whatever was printed right before the server was shut down.
This task depends upon

Closed by  Brett Cornwall (ainola)
Thursday, 24 December 2020, 06:26 GMT
Reason for closing:  Fixed
Additional comments about closing:  Updated to waybar-0.9.5-1, which includes the crash fixes without needing to backport.
Comment by Brett Cornwall (ainola) - Tuesday, 22 December 2020, 01:40 GMT
Thanks for reporting this!

This is likely to me backporting a patch [1] from the upstream repository to fix an MPD-related crash [2].

Aubergine, are you able to build the latest mater branch and see if this issue still affects you? It'd be good to know if the backport or upstream itself is the culprit.

[1] https://github.com/Alexays/Waybar/pull/887/files
[2] https://github.com/Alexays/Waybar/issues/775
Comment by Aubergine (Aubergine) - Tuesday, 22 December 2020, 06:51 GMT
Hey Brett,
I built and ran the current master (f91dc7f); the issue doesn't seem to be present.
Comment by Brett Cornwall (ainola) - Wednesday, 23 December 2020, 07:50 GMT
maximbaz, dvzrv: Would you two agree that the best COA would be to remove this patch? It appears that more than the one patch are necessary to solve the crash and I'd prefer not to backport even more. It might be best to bug upstream to cut a new release.
Comment by David Runge (dvzrv) - Wednesday, 23 December 2020, 10:18 GMT
@ainola: I would assume that a hard crash with a segfault is worse than a custom display option not being honored.
Instead of removing the patch that fixes an upstream acknowledged crash I would leave this in. Asking upstream to cut a new release is of course also a good idea.

@Aubergine:
Have you tried contacting upstream about this issue?
How are you starting mpd and would you mind sharing your waybar config that exhibits this behavior?
Comment by Brett Cornwall (ainola) - Wednesday, 23 December 2020, 20:14 GMT
I was wondering just how prevalent the bug was considering there were two users that acknowledged its existence. I was under the impression that the large patch was a requirement to make the MPD module work at all; however, the OP of this report seems to be an example of the module functioning before a downstream patch ruined it.

Anyway, I opened up a new report asking for a release:

https://github.com/Alexays/Waybar/issues/948
Comment by Brett Cornwall (ainola) - Wednesday, 23 December 2020, 21:21 GMT
waybar-0.9.5-1 has been pushed to [community]. dvzrv, Aubergine, can you both confirm that all is behaving as expected?
Comment by Aubergine (Aubergine) - Thursday, 24 December 2020, 04:14 GMT
Updated and it seems so work smoothly!
I start mpd manually when I need it, in a terminal from which I then usually run a client.
Are you still interested in my config files?

Loading...