FS#68670 - [zstd] missing cmake files

Attached to Project: Arch Linux
Opened by Observer of Time (chronobserver) - Thursday, 19 November 2020, 15:21 GMT
Last edited by David Thurstenson (thurstylark) - Saturday, 12 March 2022, 19:06 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Jelle van der Waa (jelly)
Levente Polyak (anthraxx)
Giancarlo Razzolini (grazzolini)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The zstd package is missing the following files which are required for <code>find_package(zstd)</code>:

<pre><code>
/usr/lib/cmake/zstd/zstdConfig.cmake
/usr/lib/cmake/zstd/zstdConfigVersion.cmake
/usr/lib/cmake/zstd/zstdTargets-release.cmake
/usr/lib/cmake/zstd/zstdTargets.cmake
</code></pre>

This can be solved by building the package via cmake.
This task depends upon

Closed by  David Thurstenson (thurstylark)
Saturday, 12 March 2022, 19:06 GMT
Reason for closing:  Fixed
Additional comments about closing:  zstd 1.5.2-3 (also see  FS#73333 )
Comment by Eli Schwartz (eschwartz) - Thursday, 19 November 2020, 21:19 GMT
The official build system is make, which doesn't require another makedepends. The cmake build system is a third-party contribution.

The standard for detecting dependencies is pkg-config which the current build provides; find_package only works in cmake.

I recommend instead using

find_package(PkgConfig)
pkg_check_modules(ZSTD zstd IMPORTED_TARGET GLOBAL)

then linking to PkgConfig::ZSTD instead of whatever unofficial target is provided by the cmake files you want.
Comment by Marcell Meszaros (MarsSeed) - Thursday, 10 March 2022, 19:25 GMT
 FS#73333  fixes zstd's pkgconfig. Third party builds can and should get libzstd properties from that.

Loading...