FS#6829 - pacman ignores the --sysconfdir parameter in various places

Attached to Project: Pacman
Opened by Marc - A. Dahlhaus (wraiden) - Friday, 06 April 2007, 21:08 GMT
Last edited by Roman Kyrylych (Romashka) - Tuesday, 05 June 2007, 14:29 GMT
Task Type Bug Report
Category Backend/Core
Status Closed
Assigned To Dan McGee (toofishes)
Architecture All
Severity Low
Priority Normal
Reported Version 2.9.8
Due in Version 3.1.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Hello,

i found some places where the build automation for pacman should make
use of the --sysconfdir parameter of the configure script.

- the scripts in scripts/ include config files via hardcoded path to
/etc.
- some of the config files inside sysconfdir include other files via
hardcoded path to /etc.
- the default place for config-file should use the sysconfdir in place
of the hardcoded /etc if no --with-config-file parameter is given.

I could contribute patches for this problems if desired.

Wraiden
This task depends upon

Closed by  Roman Kyrylych (Romashka)
Tuesday, 05 June 2007, 14:29 GMT
Reason for closing:  Fixed
Additional comments about closing:  in git
Comment by Aaron Griffin (phrakture) - Friday, 06 April 2007, 21:17 GMT
Patches or just indications of where these paths are would be nice - we're moving a chunk of the scripts over to .in files anyway
Comment by Dan McGee (toofishes) - Wednesday, 11 April 2007, 16:56 GMT
As Aaron said, we will probably be moving most scripts to .in equivalents for multiple reasons (hardcoded paths, gettext internationalization). Patch format would be good to point these out, although your patch may not be applied directly. Thanks for pointing this out though, we'd like to make pacman a bit more distro-agnostic.
Comment by Andrew Fyfe (space-m0nkey) - Thursday, 12 April 2007, 01:20 GMT
Dan, Aaron I've begun work on this here > http://repo.or.cz/w/pacman.git?a=shortlog;h=autoconf_scripts
Comment by Dan McGee (toofishes) - Wednesday, 30 May 2007, 20:36 GMT
Still todo:
* Seperate pacman ROOTDIR logic from configure-set paths, and make changes in the code accordingly
* Fix the ABS supfiles to respect @sysconfdir@ (or just remove mention of /etc/ from their headers)
Comment by Andrew Fyfe (space-m0nkey) - Wednesday, 30 May 2007, 20:45 GMT
For the ABS files just change the headers to 'supfile.{repo}', there's not really any need for the full path.
Comment by Dan McGee (toofishes) - Thursday, 31 May 2007, 07:19 GMT
As of tonight, this should be fixed. Testing appreciated.
Comment by Marc - A. Dahlhaus (wraiden) - Thursday, 31 May 2007, 08:20 GMT
i´ve found one remaining merely cosmetic case over gitweb:
etc/pacman.conf.in still references /etc

can someone place a tarball of the latest git content somewhere?
I´ll test my original scenario again and check if everything is nice now.
Comment by Marc - A. Dahlhaus (wraiden) - Thursday, 31 May 2007, 08:42 GMT
Found another case via gitweb:
the default value for --with-config-file should use the --sysconfdir value as basedirectory and not the hardcoded etc.
Comment by Andrew Fyfe (space-m0nkey) - Thursday, 31 May 2007, 12:05 GMT
I've setup a script to upload a snapshot of git everyday at 6:10 am UTC

http://linux.neptune-one.net/pacman/pacman-git.tar.bz2
Comment by Dan McGee (toofishes) - Thursday, 31 May 2007, 14:32 GMT
Marc- you must be looking at an outdated version or something. grep etc pacman.conf.in produces 0 results. In addition, the --with-config-file directive doesn't even exist anymore.

Loading...