FS#68281 - [kodi] does not detect sse4 and does not build libsse4-x86_64-linux.so

Attached to Project: Community Packages
Opened by John (graysky) - Friday, 16 October 2020, 11:45 GMT
Last edited by Ike Devolder (BlackEagle) - Thursday, 22 October 2020, 09:05 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Ike Devolder (BlackEagle)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Similar to  FS#53449 , it appears that /usr/lib/kodi/system/libsse4-x86_64-linux.so is not built despite cheat-sse-build.patch getting applied.

https://www.archlinux.org/packages/community/x86_64/kodi/files/

Additional info:
* package version(s) kodi-18.8-2
This task depends upon

Closed by  Ike Devolder (BlackEagle)
Thursday, 22 October 2020, 09:05 GMT
Reason for closing:  Fixed
Additional comments about closing:  kodi 18.8-4 fixes the issue
Comment by John (graysky) - Friday, 16 October 2020, 14:53 GMT
I should have added that if I remove the patch, and compile on my box (Intel Haswell with SSE4+ exts), that file is part of the package.

% ls -l /usr/lib/kodi/system
total 12
drwxr-xr-x 3 root root 4096 Oct 16 10:02 players
-rwxr-xr-x 1 root root 5776 Oct 16 10:01 libsse4-x86_64-linux.so
Comment by loqs (loqs) - Friday, 16 October 2020, 16:36 GMT
Did you try rebuilding without removing the patch on a system with SSE4+?
Comment by John (graysky) - Friday, 16 October 2020, 17:32 GMT
@loqs - Yes, when I built on the same Haswell system with the patch as-is, the resulting package did not contain libsse4-x86_64-linux.so just as 18.8-2 does not.
Comment by loqs (loqs) - Friday, 16 October 2020, 17:44 GMT
Strange I just rebuilt it as well

pacman -Qlp kodi-18.8-2-x86_64.pkg.tar.zst | grep libsse4-x86_64-linux.so
kodi /usr/lib/kodi/system/libsse4-x86_64-linux.so

find -name libsse4-x86_64-linux.so
./src/kodi-build-x11/system/libsse4-x86_64-linux.so
./src/kodi-build-wayland/system/libsse4-x86_64-linux.so
./src/kodi-build-gbm/system/libsse4-x86_64-linux.so
./pkg/kodi/usr/lib/kodi/system/libsse4-x86_64-linux.so
Comment by John (graysky) - Friday, 16 October 2020, 17:51 GMT
@loqs - Did you build via devtools?

I cleared my buildroot and an rebuilding now to verify but looking at the official package, it lacks it:

% pacman -Qlp /var/cache/pacman/pkg/kodi-18.8-2-x86_64.pkg.tar.zst| grep libsse4-x86_64-linux.so
% echo $?
1

EDIT: interestingly, after clearing the buildroot, I am able to build it using the PKGBUILD untouched. The official package definitely lacks it though.
% pacman -Qlp kodi-18.8-2-x86_64.pkg.tar.zst | grep sse
kodi /usr/lib/kodi/system/libsse4-x86_64-linux.so
Comment by Ike Devolder (BlackEagle) - Saturday, 17 October 2020, 15:12 GMT
I'll have a look, I have 2 machines packages are built on, one has no hardware support for SSE4, but the patch "should" fix that. I'll push out a rebuild once its resolved.
Comment by Geert Hendrickx (ghen) - Monday, 19 October 2020, 09:38 GMT
The absolute path "/build/kodi/src/cpuinfo" is only valid on some build systems? Can it use a relative path instead?
Comment by Geert Hendrickx (ghen) - Monday, 19 October 2020, 09:42 GMT
Or alter the patch to set the CPUINFO variable directly instead of catting a /proc/cpuinfo replacement.
Comment by Ike Devolder (BlackEagle) - Thursday, 22 October 2020, 09:04 GMT
Thanks @ghen, I never revisited the "cheat" because it just worked :)

Loading...