FS#68275 - [osquery] FTBFS with glibc 2.32 or aws-sdk-cpp 1.8.46

Attached to Project: Community Packages
Opened by loqs (loqs) - Thursday, 15 October 2020, 21:01 GMT
Last edited by Doug Newgard (Scimmia) - Wednesday, 21 October 2020, 03:41 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Anatol Pomozov (anatolik)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
osquery fails to build from source [1]. As upstream vendors dependencies at least the aws-sdk-cpp failure is not an upstream issue.
Builds after applying patches [2] and [3]. [4] for future boost 1.74 compatibility.

Additional info:
* osquery 4.4.0-1
* aws-sdk-cpp-1.8.46-1
* glibc 2.32-5
[1] pkgbuild.log
[2] aws-sdk-cpp.patch
[3] glibc.patch
[4] boost-1_74.patch

Steps to reproduce:
   pkgbuild.log (233.8 KiB)
   aws-sdk-cpp.patch (3.9 KiB)
   glibc.patch (1.5 KiB)
   boost-1_74.patch (11 KiB)
This task depends upon

Closed by  Doug Newgard (Scimmia)
Wednesday, 21 October 2020, 03:41 GMT
Reason for closing:  Fixed
Additional comments about closing:  osquery 4.5.1-1
Comment by loqs (loqs) - Friday, 16 October 2020, 04:01 GMT
Source tar ball for 4.5.1 including updated patches.
Shows the additional changes I made to make 4.5.1 build. I had to adjust some of devendorize.patch to apply and made additional changes to it for 4.51 to build.
The upstream commit I reverted is https://github.com/osquery/osquery/commit/ea70cde29d9095f35ad4c97bb013bce6af0681c9
(application/x-gzip)    osquery-4.5.1-1.src.tar.gz (28.9 KiB)
Comment by Anatol Pomozov (anatolik) - Friday, 16 October 2020, 16:45 GMT
woah, thank you for taking care of it.

Is there any change you can put these patches on top of the `archlinux` branch instead? https://github.com/anatol/osquery/tree/archlinux This way the author information + commit messages will be preserved.

Then I pull your reworked tree and update PKGBUILD to 4.5.1.
Comment by Anatol Pomozov (anatolik) - Friday, 16 October 2020, 16:46 GMT
And plus it is a good idea to let upstream know about your patches. They might want to pull it into master branch.
Comment by Anatol Pomozov (anatolik) - Friday, 16 October 2020, 18:45 GMT
Or let me know if you prefer I put the patches to the git tree myself.
Comment by loqs (loqs) - Friday, 16 October 2020, 19:02 GMT
I can attempt it over the weekend. Have you had a chance to test if the patches work?
Comment by loqs (loqs) - Friday, 16 October 2020, 21:09 GMT
Applied on top of the archlinux branch.
   devendorize.patch (150.3 KiB)
Comment by Anatol Pomozov (anatolik) - Saturday, 17 October 2020, 02:59 GMT
Thank you for your work. I applied your patches to this tree https://github.com/anatol/osquery/tree/archlinux and osquery builds fine with it.

osquery-4.5.1 is in [community-testing]. PTAL.
Comment by loqs (loqs) - Saturday, 17 October 2020, 03:37 GMT
Worked for my very limited testing. I like the concept of exposing the data through SQL and can see why you went through the effort to devendorize it.

Loading...