FS#68165 - [nvchecker] add nvhecker-notify script to package release

Attached to Project: Community Packages
Opened by Hans-Nikolai Viessmann (hv15) - Friday, 09 October 2020, 08:31 GMT
Last edited by Chih-Hsuan Yen (yan12125) - Tuesday, 03 November 2020, 15:49 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Felix Yan (felixonmars)
Chih-Hsuan Yen (yan12125)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Hi, since v2 of nvchecker, the inbuilt support for desktop-notification was removed (previously activated using the `-n` flag). As an alternative, the author upstream provides the `nvchecker-notify` script which wraps around nvchecker to show desktop-notifications (see upstream issue https://github.com/lilydjwg/nvchecker/issues/158). Could this script be added to the nvchecker package please?
This task depends upon

Closed by  Chih-Hsuan Yen (yan12125)
Tuesday, 03 November 2020, 15:49 GMT
Reason for closing:  Implemented
Additional comments about closing:  nvchecker 2.2-1
Comment by Chih-Hsuan Yen (yan12125) - Friday, 09 October 2020, 11:52 GMT
Oh, I thought the notify script is included in sources of version 2.1 but just not installed, which is not the case.

The good news is that upstream agrees to install that script by default [1], so it will be included in the next version of community/nvchecker.

[1] https://github.com/lilydjwg/nvchecker/issues/158#issuecomment-706121441
Comment by Hans-Nikolai Viessmann (hv15) - Friday, 09 October 2020, 12:53 GMT
Awesome, thank you!
Comment by Chih-Hsuan Yen (yan12125) - Tuesday, 03 November 2020, 15:48 GMT
nvchecker 2.2 is out and uploaded to [community]!

Loading...