FS#68020 - [facter] has missing dependencies

Attached to Project: Community Packages
Opened by Tim (bastelfreak) - Sunday, 27 September 2020, 21:37 GMT
Last edited by Thore Bödecker (foxxx0) - Monday, 16 November 2020, 09:27 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Thore Bödecker (foxxx0)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description: Hi facter with our minimal vagrant images looks like this:

```
2020-09-27 21:31:28.068760 WARN puppetlabs.facter - could not locate a ruby library: facts requiring Ruby will not be resolved.
{
architecture => "x86_64",
family => "Archlinux",
hardware => "x86_64",
name => "Archlinux",
release => {
full => "5.7.12-arch1-1",
major => "5",
minor => "7"
},
selinux => {
enabled => false
}
}
```

this is latest facter:

```
# pacman -Qi facter
Name : facter
Version : 3.14.13-1
Description : Collect and display system facts
Architecture : x86_64
URL : https://puppetlabs.com/facter
Licenses : APACHE
Groups : None
Provides : libfacter.so=3.14.13-64
Depends On : yaml-cpp boost-libs curl libwhereami libwhereami.so=0.5.0-64 cpp-hocon libcpp-hocon.so=0.3.0-64 systemd-libs leatherman leatherman_curl.so=1.12.0-64 leatherman_ruby.so=1.12.0-64
leatherman_execution.so=1.12.0-64 leatherman_file_util.so=1.12.0-64 leatherman_util.so=1.12.0-64 leatherman_logging.so=1.12.0-64 leatherman_locale.so=1.12.0-64 openssl gcc-libs glibc libutil-linux
libblkid.so=1-64 yaml-cpp
Optional Deps : java-runtime>=8: jruby support
puppet: retrieve puppet facts
Required By : None
Optional For : None
Conflicts With : None
Replaces : cfacter
Installed Size : 2.17 MiB
Packager : Thore Bödecker <foxxx0@archlinux.org>
Build Date : Wed 26 Aug 2020 09:12:49 AM UTC
Install Date : Sun 27 Sep 2020 09:29:52 PM UTC
Install Reason : Explicitly installed
Install Script : No
Validated By : Signature
```

after installing ruby:

```
# facter os
{
architecture => "x86_64",
family => "Archlinux",
hardware => "x86_64",
name => "Archlinux",
release => {
full => "5.7.12-arch1-1",
major => "5",
minor => "7"
},
selinux => {
enabled => false
}
}
```

one could now argue if it's a soft-dep or not. In my opinion it's a hard one because facters throws an error

besides ruby, there is also lsb-release missing. there is currently no distro hash in the facter output. But puppet assumes it's always there. It appears after installing lsb-release:

```

# facter os
{
architecture => "x86_64",
distro => {
codename => "n/a",
description => "Arch Linux",
id => "Arch",
release => {
full => "rolling",
major => "rolling"
},
specification => "1.4"
},
family => "Archlinux",
hardware => "x86_64",
name => "Archlinux",
release => {
full => "5.7.12-arch1-1",
major => "5",
minor => "7"
},
selinux => {
enabled => false
}
}
```

tl;dr please add ruby and lsb-release as runtime dependencies to facter.


cheers, Tim
This task depends upon

Closed by  Thore Bödecker (foxxx0)
Monday, 16 November 2020, 09:27 GMT
Reason for closing:  Fixed
Additional comments about closing:  fixed as of facter-3.14.14-4
Comment by Doug Newgard (Scimmia) - Sunday, 27 September 2020, 21:48 GMT
I do feel compelled to point out one of the previous tickets you opened:  FS#62674 
Comment by Tim (bastelfreak) - Monday, 28 September 2020, 11:02 GMT
I'm not sure if I noticed this warning when I raised https://bugs.archlinux.org/task/62674 or if the message is new. Also I'm unsure if we should consider it an optional dependency or not. I'm fine with keeping it optional. However I vote for adding lsb-release as a dependency.

Loading...