Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#67972 - [shairport-sync] enable jack output

Attached to Project: Community Packages
Opened by Andrea (BrainDamage) - Wednesday, 23 September 2020, 04:17 GMT
Last edited by Anatol Pomozov (anatolik) - Friday, 25 September 2020, 18:08 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Anatol Pomozov (anatolik)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

shairport-sync version 3.3.6

shairport-sync has an optional jack output backend, in order to enable it one would enable it with --with-jack option in the makefile as usual
since version 3.3.6 it supports high quality resampling so it should be on par as usability as the other backends
This task depends upon

Closed by  Anatol Pomozov (anatolik)
Friday, 25 September 2020, 18:08 GMT
Reason for closing:  Implemented
Additional comments about closing:  shairport-sync-3.3.6-2
Comment by Anatol Pomozov (anatolik) - Wednesday, 23 September 2020, 16:23 GMT
shairport-sync-3.3.6-2 added --with-jack flag. Please take a look and let me know if it works as expected.
Comment by Andrea (BrainDamage) - Friday, 25 September 2020, 11:46 GMT
Unfortunately the backend fails with an abort assertion, I guess I'll have to file an upstream bug. Thanks for the task though.
Comment by Anatol Pomozov (anatolik) - Friday, 25 September 2020, 15:50 GMT
What is the abort messsage? Could you please post it here? And once the upsteram bug is filed could you please add a link to it?
Comment by Andrea (BrainDamage) - Friday, 25 September 2020, 17:34 GMT
A fairly generic one, even with max verbosity:
~❯ shairport-sync -vvv
[1] 20301 abort (core dumped) shairport-sync -vvv

EDIT:

after rebuilding with debug flags I've found it was a case of PEBKAC, but the way the error is delivered is unreadable for most users:

Thread 1 "shairport-sync" received signal SIGABRT, Aborted.
0x00007ffff7735615 in raise () from /usr/lib/libc.so.6
(gdb) threa apply all bt

Thread 3 (Thread 0x7ffff69e9640 (LWP 65578)):
#0 0x00007ffff7a1c00c in read () from /usr/lib/libpthread.so.0
#1 0x00007ffff7ed7d6f in ?? () from /usr/lib/libjack.so.0
#2 0x00007ffff7edcc59 in ?? () from /usr/lib/libjack.so.0
#3 0x00007ffff7ed6b1d in ?? () from /usr/lib/libjack.so.0
#4 0x00007ffff7a123e9 in start_thread () from /usr/lib/libpthread.so.0
#5 0x00007ffff77f8293 in clone () from /usr/lib/libc.so.6

Thread 2 (Thread 0x7ffff6a6a640 (LWP 65577)):
#0 0x00007ffff7a186a2 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
#1 0x00007ffff7ed75f0 in ?? () from /usr/lib/libjack.so.0
#2 0x00007ffff7ecee16 in ?? () from /usr/lib/libjack.so.0
#3 0x00007ffff7ed6b1d in ?? () from /usr/lib/libjack.so.0
#4 0x00007ffff7a123e9 in start_thread () from /usr/lib/libpthread.so.0
#5 0x00007ffff77f8293 in clone () from /usr/lib/libc.so.6

Thread 1 (Thread 0x7ffff6c80840 (LWP 65571)):
#0 0x00007ffff7735615 in raise () from /usr/lib/libc.so.6
#1 0x00007ffff771e862 in abort () from /usr/lib/libc.so.6
#2 0x0000555555565d10 in _die (filename=filename@entry=0x55555558826d "audio_jack.c", linenumber=linenumber@entry=275, format=format@entry=0x555555587fc0 "The JACK server is running at the wrong sample rate (%d) for Shairport Sync. Must be 44100 Hz.") at common.c:239
#3 0x00005555555785cd in jack_init (argc=<optimized out>, argv=<optimized out>) at audio_jack.c:275
#4 0x000055555555b3e3 in main (argc=<optimized out>, argv=0x7fffffffc2e8) at shairport.c:1673

After switching the sample rate it works.
Comment by Anatol Pomozov (anatolik) - Friday, 25 September 2020, 17:41 GMT
Good to hear about the progress.

1. Should we keep --jack enabled for the Arch package?
2. wrt the error message issue - it sounds like upstream should handle it correctly.
Comment by Andrea (BrainDamage) - Friday, 25 September 2020, 18:03 GMT
1. I would say yes, the problem doesn't seem limited to the jack backend, it's an universal issue with the logging system.
2. I totally agree and will file a bug upstream.
Comment by Anatol Pomozov (anatolik) - Friday, 25 September 2020, 18:05 GMT
great. shairport-sync-3.3.6-2 has been pushed to [stable].

Loading...