FS#67854 - [python-toml] install type hints
Attached to Project:
Community Packages
Opened by Filipe Laíns (FFY00) - Wednesday, 09 September 2020, 00:10 GMT
Last edited by David Runge (dvzrv) - Sunday, 13 September 2020, 20:19 GMT
Opened by Filipe Laíns (FFY00) - Wednesday, 09 September 2020, 00:10 GMT
Last edited by David Runge (dvzrv) - Sunday, 13 September 2020, 20:19 GMT
|
Details
The project provides a `toml.pyi` file with type hints but
it is not installed. Would it be possible to install it?
|
This task depends upon
Closed by David Runge (dvzrv)
Sunday, 13 September 2020, 20:19 GMT
Reason for closing: Upstream
Additional comments about closing: This ultimately is still an upstream issue and therefore should be dealt with there. Eventually changes there will make it to our packages anyways.
However, as you have already supplied a patch to upstream I have added the file as well.
python-toml 0.10.1-2
Sunday, 13 September 2020, 20:19 GMT
Reason for closing: Upstream
Additional comments about closing: This ultimately is still an upstream issue and therefore should be dealt with there. Eventually changes there will make it to our packages anyways.
However, as you have already supplied a patch to upstream I have added the file as well.
python-toml 0.10.1-2
https://github.com/uiri/toml/issues/316
As much as I like the type hints to be included I think this ultimately to be an upstream issue.
Both tickets linked to by @polyzen are relevant here and once they are resolved the file should a) be correct and b) be installed by setuptools.
As referred in issue #304, the type hints are incomplete, not incorrect. Part of the API still doesn't have type hints, but this shouldn't block us from installing the type hints.
I don't think the upstream *needs* to make sure the type hints are installed via setuptools for us to provide them in the package, we could still install the file ourselves. I understand if you disagree.
https://github.com/uiri/toml/pull/318