FS#67628 - [distcc] unable to build 3.3.3-

Attached to Project: Community Packages
Opened by John (graysky) - Tuesday, 18 August 2020, 13:18 GMT
Last edited by Alexander F. Rødseth (xyproto) - Monday, 07 September 2020, 19:21 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Alexander F. Rødseth (xyproto)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I am unable to build 3.3.3-5 in a clean chroot. The error is highlighted below, complete build log attached.

Short error:
/build/distcc/src/distcc/include_server/c_extensions/distcc_pump_c_extensions_module.c: In function ‘XArgv’:
/build/distcc/src/distcc/include_server/c_extensions/distcc_pump_c_extensions_module.c:214:13: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
214 | argv[i] = PyUnicode_AsUTF8(string_object); /* does not increase
| ^
   build.log (79 KiB)
This task depends upon

Closed by  Alexander F. Rødseth (xyproto)
Monday, 07 September 2020, 19:21 GMT
Reason for closing:  Fixed
Comment by Doug Newgard (Scimmia) - Tuesday, 18 August 2020, 14:21 GMT
The error is long before that. It's likely the lines:

/usr/bin/ld: src/serve.o:(.bss+0x0): multiple definition of `stats_text'; src/prefork.o:(.bss+0x0): first defined here
/usr/bin/ld: src/stats.o:(.data.rel.local+0x0): multiple definition of `stats_text'; src/prefork.o:(.bss+0x0): first defined here

So adding -fcommon to CFLAGS may be all that's needed.
Comment by John (graysky) - Tuesday, 18 August 2020, 14:26 GMT
@scimmia - Thanks for pointing that out. Interestingly, if I build using distcc-git from the AUR, I receive no such errors. The package here in [community] is very similar to the AUR package so I am thinking there is something in the upstream code causing this build error.
Comment by Doug Newgard (Scimmia) - Tuesday, 18 August 2020, 14:38 GMT
If upstream's on top of it, they would have updated the code for GCC10's defaults, so that's entirely possible. Whether they just added -fcommon or actually fixed the code, I don't know.
Comment by John (graysky) - Wednesday, 19 August 2020, 23:28 GMT
@scimmia - Per your suggestion, I added the following to the build function and it built just fine:

CFLAGS+=" -fcommon"

@xyproto - Might want to just do that and call it good.
Comment by Alexander F. Rødseth (xyproto) - Monday, 07 September 2020, 19:20 GMT
Added the -fcommon flag. Thanks for the bug report and tips!

Loading...