FS#67486 - [benchmark] Not built with Release
Attached to Project:
Community Packages
Opened by Zulan (Zulan) - Tuesday, 04 August 2020, 16:03 GMT
Last edited by Massimiliano Torromeo (mtorromeo) - Friday, 28 August 2020, 07:45 GMT
Opened by Zulan (Zulan) - Tuesday, 04 August 2020, 16:03 GMT
Last edited by Massimiliano Torromeo (mtorromeo) - Friday, 28 August 2020, 07:45 GMT
|
Details
Description:
The package is built with the default build type instead of the recommended "Release" build type. This causes undesired slowdown and a corresponding warning. See https://github.com/google/benchmark#debug-vs-release Suggested change: replace -DCMAKE_BUILD_TYPE=None with -DCMAKE_BUILD_TYPE=Release Additional info: * package version(s) 1.5.1 * config and/or log files etc. > ***WARNING*** Library was built as DEBUG. Timings may be affected. * link to upstream bug report, if any https://github.com/google/benchmark/issues/178 (known, documented, behavior) Steps to reproduce: Build anything with benchmark and run it. |
This task depends upon
Closed by Massimiliano Torromeo (mtorromeo)
Friday, 28 August 2020, 07:45 GMT
Reason for closing: Fixed
Additional comments about closing: benchmark-1.5.1-
Friday, 28 August 2020, 07:45 GMT
Reason for closing: Fixed
Additional comments about closing: benchmark-1.5.1-
Comment by
Massimiliano Torromeo (mtorromeo) -
Sunday, 09 August 2020, 16:05 GMT
Should be fixed in benchmark-1.5.1-2. Please let me know if it's
ok now.