FS#67427 - [chromium] Consider staying pristine with upstream without chromium-fix-vaapi-on-intel.patch

Attached to Project: Arch Linux
Opened by KJ Liew (liewkj) - Tuesday, 28 July 2020, 18:45 GMT
Last edited by Evangelos Foutras (foutrelis) - Wednesday, 07 October 2020, 21:47 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Evangelos Foutras (foutrelis)
Felix Yan (felixonmars)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
Please consider staying pristine with upstream by removing chromium-fix-vaapi-on-intel.patch on next upstream release. Build flag `use_vaapi=true` should be good enough.

The patch disabled potential power-saving improvements from upstream for Intel GPUs that support it (from ChromeOS).
https://chromium-review.googlesource.com/c/chromium/src/+/2246846

For Intel GPUs that are affected, they can go back to AUR which still incorporates the patch.
This task depends upon

Closed by  Evangelos Foutras (foutrelis)
Wednesday, 07 October 2020, 21:47 GMT
Reason for closing:  Implemented
Additional comments about closing:  chromium 86.0.4240.75-1 (patch doesn't seem to be needed anymore)
Comment by Felix Yan (felixonmars) - Wednesday, 29 July 2020, 06:07 GMT
Do you have a working example of kNone with Kaby Lake or newer Intel chip on Arch? Since all testers I contacted with these chips are having playback issues I don't think the power-saving improvements are useful anyway.
Comment by KJ Liew (liewkj) - Thursday, 30 July 2020, 07:16 GMT
I do not have the answer since recent Intel GPUs that would prove the power-saving code path are not at my disposal. I presumed Google's test data would apply universally especially for "-U" or "Core M" series of KabyLake/KabyLake-R or later models since the statistics was profiled from media hardware block.
Comment by Felix Yan (felixonmars) - Thursday, 30 July 2020, 11:26 GMT
I am having an i7-8650U and kNone doesn't work for me either. My guess would be that this has something to do with their patching to their intel libva libraries:

https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/master/x11-libs/libva-intel-driver/files/
https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/master/x11-libs/libva-intel-media-driver/files/
Comment by KJ Liew (liewkj) - Friday, 31 July 2020, 22:01 GMT
Thanks for the pointers. Good to know that ChromeOS is indeed using patched libva/va drivers.

Loading...