FS#67149 - [libkkc-data] missing python2-marisa make dependency

Attached to Project: Community Packages
Opened by tinywrkb (tinywrkb) - Monday, 29 June 2020, 22:14 GMT
Last edited by Jelle van der Waa (jelly) - Friday, 14 May 2021, 14:27 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Felix Yan (felixonmars)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

libkkc-data is not reproducible due to missing make dependency python2-marisa.

I suggest the following changes to libkkc and libkkc-data.

I have not tested if python-marisa is actually still required, and I don't know if this breaks anything as I don't use the package and only notice this because I'm building fcitx.
   libkkc.patch (1.8 KiB)
   libkkc-data.patch (0.9 KiB)
This task depends upon

Closed by  Jelle van der Waa (jelly)
Friday, 14 May 2021, 14:27 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in 0.2.7-3
Comment by Doug Newgard (Scimmia) - Monday, 29 June 2020, 22:28 GMT
To clarify, the dep listing isn't missing, the package itself it.
Comment by tinywrkb (tinywrkb) - Saturday, 11 July 2020, 18:39 GMT
Here's an alternative patch that avoids running kkc-package-data during makepkg. This just a diff against the updated libkkc-data tarball generated by kkc-package-data from libkkc gitmaster HEAD.
With this patch there's no need for adding libkkc as a dependency of libkkc-data so no need to bump libkkc release to checkout master branch and pull in the latest python3 fixes.
And I confirmed that python-marisa is needed as a make dependency for libkkc-data.

   0001-libkkc-data-update-build... (113.2 KiB)
Comment by tinywrkb (tinywrkb) - Monday, 07 September 2020, 12:37 GMT
Still no response from the maintainer.
Here's another alternative that uses the [patch from the debian package](https://salsa.debian.org/input-method-team/libkkc-data/-/blob/master/debian/patches/0001-tools-Import-upstream-py3-compat-version.patch).

   0001-libkkc-data-import-debia... (8.9 KiB)

Loading...