Release Engineering


FS#66933 - [archiso] mkarchiso script var quoting

Attached to Project: Release Engineering
Opened by digimokan (digimokan) - Sunday, 07 June 2020, 22:20 GMT
Last edited by David Runge (dvzrv) - Wednesday, 01 July 2020, 06:29 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Pierre Schmitz (Pierre)
David Runge (dvzrv)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No



When the /usr/bin/mkarchiso script is called from a directory with spaces in its name, the script fails, with this error:

/usr/bin/mkarchiso: line 254: cd: too many arguments

Lines 254 and 264 use the variable ${OLDPWD}. This variable needs to be quoted: "${OLDPWD}".

Additional info:

* package version 44-2

Steps to reproduce:

1. Create a directory with a space in its name.
2. For ArchWiki Archiso "Setup" step, use this space-name directory as the "archlive" build directory:
cp -r /usr/share/archiso/configs/profile/ archlive
3. When executing the script from this space-name directory, the bug will present.
This task depends upon

Closed by  David Runge (dvzrv)
Wednesday, 01 July 2020, 06:29 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed with v45
Comment by David Runge (dvzrv) - Thursday, 11 June 2020, 10:47 GMT
@digimokan: Thanks for the report! That's sadly not the only location where we have unquoted vars in that script ;-)

I'll create a ticket on our gitlab for it and fix it for the next release this month!
Comment by digimokan (digimokan) - Saturday, 13 June 2020, 17:52 GMT
You bet! Yes, I did notice that too. :)

Thank you for the good work. I don't know what I would do without mkarchiso.