Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#66867 - [pacman-contrib] updpkgsums misbehaviour

Attached to Project: Community Packages
Opened by Amin Vakil (aminvakil) - Tuesday, 02 June 2020, 16:20 GMT
Last edited by Johannes Löthberg (demize) - Saturday, 21 November 2020, 13:32 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Johannes Löthberg (demize)
Daniel M. Capella (polyzen)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

I maintain tor-browser-behind-tor AUR package (https://aur.archlinux.org/packages/tor-browser-behind-tor) and tor-browser AUR package (https://aur.archlinux.org/packages/tor-browser) has recently updated to 9.5 version, so I wanted to upgrade my package as well.

So I edited pkgver in PKGBUILD from 9.0.10 to 9.5 and ran updpkgsums, it ran without any errors but it adds two extra lines in PKGBUILD which broke it and makepkg gives me this error:

xxx/tor-browser-behind-tor/PKGBUILD: line 97: syntax error near unexpected token `)'
xxx/tor-browser-behind-tor/PKGBUILD: line 97: ` 'SKIP')'

It should change to:
sha256sums_x86_64=('08fca06954b1119291b1d298f59683e9b44bd428db1215a3c562f337bff88e50'
'SKIP')

but updpkgsums changed it to:
sha256sums_x86_64=('08fca06954b1119291b1d298f59683e9b44bd428db1215a3c562f337bff88e50'
'SKIP')
'SKIP')
'SKIP')

I doubt this has to do anything with this specific PKGBUILD and it would be something different.

Additional info:
Package version: pacman-contrib-1.3.0-2

Steps to reproduce:
git clone https://aur.archlinux.org/tor-browser-behind-tor.git
Change 9.0.10 to 9.5
updpkgsums
This task depends upon

Closed by  Johannes Löthberg (demize)
Saturday, 21 November 2020, 13:32 GMT
Reason for closing:  Won't fix
Additional comments about closing:  Supporting checksum arrays that don't just contain checksums is out of scope for pacman-contrib.
Comment by Amin Vakil (aminvakil) - Tuesday, 02 June 2020, 16:38 GMT
I don't know if I was clear or not, so here goes:

[user@hostname aur]$ git clone ssh://aur.archlinux.org/tor-browser-behind-tor.git
Cloning into 'tor-browser-behind-tor'...
remote: Enumerating objects: 55, done.
remote: Counting objects: 100% (55/55), done.
remote: Compressing objects: 100% (27/27), done.
remote: Total 55 (delta 28), reused 53 (delta 28), pack-reused 0
Receiving objects: 100% (55/55), 47.32 KiB | 526.00 KiB/s, done.
Resolving deltas: 100% (28/28), done.
[user@hostname aur]$ cd tor-browser-behind-tor/
[user@hostname tor-browser-behind-tor]$ nano PKGBUILD

Changing 9.0.10 to 9.5

[user@hostname tor-browser-behind-tor]$ updpkgsums
==> Retrieving sources...
-> Found tor-browser.desktop
-> Found tor-browser.png
-> Found tor-browser.sh
-> Downloading tor-browser-linux32-9.5_en-US.tar.xz...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 76.8M 100 76.8M 0 0 565k 0 0:02:19 0:02:19 --:--:-- 492k
-> Downloading tor-browser-linux32-9.5_en-US.tar.xz.asc...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 801 100 801 0 0 722 0 0:00:01 0:00:01 --:--:-- 722
-> Downloading tor-browser-linux64-9.5_en-US.tar.xz...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 75.3M 100 75.3M 0 0 488k 0 0:02:38 0:02:38 --:--:-- 461k
-> Downloading tor-browser-linux64-9.5_en-US.tar.xz.asc...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 801 100 801 0 0 696 0 0:00:01 0:00:01 --:--:-- 696
==> Generating checksums for source files...
[user@hostname tor-browser-behind-tor]$ makepkg -sri
/path/to/aur/tor-browser-behind-tor/PKGBUILD: line 97: syntax error near unexpected token `)'
/path/to/aur/tor-browser-behind-tor/PKGBUILD: line 97: ` 'SKIP')'
==> ERROR: Failed to source /path/to/aur/tor-browser-behind-tor/PKGBUILD
[user@hostname tor-browser-behind-tor]$ sed -i '97d' PKGBUILD
[user@hostname tor-browser-behind-tor]$ makepkg -sri
/path/to/aur/tor-browser-behind-tor/PKGBUILD: line 97: syntax error near unexpected token `)'
/path/to/aur/tor-browser-behind-tor/PKGBUILD: line 97: ` 'SKIP')'
==> ERROR: Failed to source /path/to/aur/tor-browser-behind-tor/PKGBUILD
[user@hostname tor-browser-behind-tor]$ sed -i '97d' PKGBUILD
[user@hostname tor-browser-behind-tor]$ makepkg -sri
==> Making package: tor-browser-behind-tor 9.5-1 (Tue 02 Jun 2020 09:04:46 PM +0430)
==> Checking runtime dependencies...

And everything is fine
Comment by Amin Vakil (aminvakil) - Tuesday, 02 June 2020, 16:56 GMT
So I think I've figured out what causes the problem:

In tor-browser PKGBUILD these lines are present:

sha256sums_i686=($(_dist_checksum "${_tag_i686}")
'SKIP')
sha256sums_x86_64=($(_dist_checksum "${_tag_x86_64}")
'SKIP')

They cause this issue and after running updpkgsums they change to:
sha256sums_i686=('03772768e694562bd89ac435411b3a483cdcc5c809df238e4646f3a83ce48ac0'
'SKIP')
sha256sums_x86_64=('08fca06954b1119291b1d298f59683e9b44bd428db1215a3c562f337bff88e50'
'SKIP')
'SKIP')
'SKIP')

I don't know why this happens, but as tor-browser-behind-tor has been updated, you can check it with tor-browser aur package after downgrading to 9.0.10 for example like this:

[user@hostname aur]$ git clone https://aur.archlinux.org/tor-browser.git
Cloning into 'tor-browser'...
remote: Enumerating objects: 358, done.
remote: Counting objects: 100% (358/358), done.
remote: Compressing objects: 100% (166/166), done.
remote: Total 358 (delta 225), reused 320 (delta 192), pack-reused 0
Receiving objects: 100% (358/358), 102.04 KiB | 7.85 MiB/s, done.
Resolving deltas: 100% (225/225), done.
[user@hostname aur]$ cd tor-browser/
[user@hostname tor-browser]$ nano PKGBUILD

Change pkgver=9.5 to pkgver=9.0.10

[user@hostname tor-browser]$ updpkgsums
==> Retrieving sources...
-> Found tor-browser.desktop
-> Found tor-browser.png
-> Found tor-browser.sh
-> Downloading tor-browser-linux32-9.0.10_en-US.tar.xz...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 77.8M 100 77.8M 0 0 41.6M 0 0:00:01 0:00:01 --:--:-- 41.5M
-> Downloading tor-browser-linux32-9.0.10_en-US.tar.xz.asc...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 801 100 801 0 0 20025 0 --:--:-- --:--:-- --:--:-- 20025
-> Downloading tor-browser-linux64-9.0.10_en-US.tar.xz...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 76.4M 100 76.4M 0 0 53.0M 0 0:00:01 0:00:01 --:--:-- 53.0M
-> Downloading tor-browser-linux64-9.0.10_en-US.tar.xz.asc...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 801 100 801 0 0 21078 0 --:--:-- --:--:-- --:--:-- 21078
==> Generating checksums for source files...
[user@hostname tor-browser]$ makepkg -sri
/path/to/aur/tor-browser/PKGBUILD: line 97: syntax error near unexpected token `)'
/path/to/aur/tor-browser/PKGBUILD: line 97: ` 'SKIP')'
==> ERROR: Failed to source /path/to/aur/tor-browser/PKGBUILD

Loading...