Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#66565 - [libvirt] 6.3.0-1 Make build more reproducible

Attached to Project: Community Packages
Opened by loqs (loqs) - Wednesday, 06 May 2020, 17:35 GMT
Last edited by freswa (frederik) - Sunday, 11 October 2020, 21:13 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Christian Rebischke (Shibumi)
Robin Broda (coderobe)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
/etc/libvirt/qemu/networks/default.xml contains a per build generated UUID to make the build more reproducible drop the UUID from the stored file and add it back using an install script if the file does not already contain one.

Additional info:
* [libvirt] 6.3.0-1
* /etc/libvirt/qemu/networks/default.xml
This task depends upon

Closed by  freswa (frederik)
Sunday, 11 October 2020, 21:13 GMT
Reason for closing:  Implemented
Additional comments about closing:  6.3.0-3
Comment by Robin Broda (coderobe) - Wednesday, 06 May 2020, 21:06 GMT
The fix i just pushed in 6.3.0-2 is hopefully enough - please test if that horribly breaks things, though
Comment by loqs (loqs) - Wednesday, 06 May 2020, 21:23 GMT
I made a mistake in the initial implementation just removing the UUID without putting it back.

New approach remove the UUID's value leaving the string <uuid></uuid>. In the install script if the file exists match <uuid></uuid> replacing with a newly generated UUID.

Thank you for looking into this.
   PKGBUILD.diff (1.4 KiB)
Comment by Robin Broda (coderobe) - Wednesday, 06 May 2020, 22:36 GMT
I applied your patch and released a 6.3.0-3 - is that all that's needed, and - most importantly - does it work?
Thanks for your patches
Comment by Jan Alexander Steffens (heftig) - Wednesday, 06 May 2020, 22:38 GMT
Can't we just hardcode a single UUID?
Comment by loqs (loqs) - Wednesday, 06 May 2020, 23:16 GMT
Hardcoding the UUID was effectively what the previous releases did and there were no reports of issues with it.
I tested 6.3.0-3 new install no config /etc/libvirt/qemu/networks/default.xml created with UUID inserted.
On update the UUID was not changed. Networking started after installing required dependencies.

Loading...