Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#66561 - [xdg-desktop-portal-gtk] remove gnome-keyring from depends?

Attached to Project: Arch Linux
Opened by tinywrkb (tinywrkb) - Wednesday, 06 May 2020, 12:48 GMT
Last edited by Toolybird (Toolybird) - Monday, 02 January 2023, 00:46 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Bartłomiej Piotrowski (Barthalion)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

Is there a reason for gnome-keyring being a dependency of xdg-desktop-portal-gtk?
It doesn't look like it's needed for compiling and unless I'm missing something the portal API doesn't even need a secret service bus access so it should not depend even on org.freedesktop.secrets.
I suggest removing the gnome-keyring dependency and making org.freedesktop.secrets an optional dependency of flatpak.

See Fedora packaging:
https://src.fedoraproject.org/rpms/xdg-desktop-portal-gtk/blob/master/f/xdg-desktop-portal-gtk.spec
https://src.fedoraproject.org/rpms/xdg-desktop-portal/blob/master/f/xdg-desktop-portal.spec
This task depends upon

Closed by  Toolybird (Toolybird)
Monday, 02 January 2023, 00:46 GMT
Reason for closing:  Fixed
Additional comments about closing:  xdg-desktop-portal-gtk 1.10.0-2
Comment by tinywrkb (tinywrkb) - Sunday, 10 May 2020, 11:53 GMT
I gave this another look and it seems I was wrong about the portal API, there's a secret portal but the online docs are not updated so I missed it.
Still, xdg-desktop-portal-gtk does not implement the secret portal so it should not be dependent on gnome-keyring.
gnome-keyring is the one implementing the secret portal so xdg-desktop-portal should be the one depending on gnome-keyring directly.

Related code:
https://github.com/flatpak/xdg-desktop-portal/commit/aa42ec937528141211fb5cc29faecad9981f2830
https://github.com/GNOME/gnome-keyring/commit/4010e268e6b88668e4ff017538ec42096057591c
Comment by Simon (smrqdt) - Tuesday, 09 June 2020, 19:32 GMT
ack, please remove this dependency as this messes up setups using different implementations of the d-bus secret service api (e.g. keepassxc or KWallet)
Comment by tinywrkb (tinywrkb) - Saturday, 13 June 2020, 22:31 GMT
@smrqdt this won't make a change for your issue because keepassxc does not implement the Secret Portal and xdg-desktop-portal should require a Secret Portal implementation which only gnome-keyring provides, so it would still be pulled in and would probably even auto-started by d-bus when Flatpak is used.
If you want this solved then keepasscx should first implement the Secret Portal and then both gnome-keyring and keepasscx should add xdg-desktop-portal-secret-imp` to their provides array, and according to my suggestion xdg-desktop-portal will add xdg-desktop-portal-secret-impl to its requires array.

Loading...