Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#66325 - [nim] Missing nimsuggest source files

Attached to Project: Community Packages
Opened by Matthieu Rakotojaona (rakoo) - Monday, 20 April 2020, 16:03 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:01 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Levente Polyak (anthraxx)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Upstream archive (https://github.com/nim-lang/Nim/archive/v1.2.0.tar.gz), as downloaded by PKGBUILD, contains a bunch of nimsuggest source files:


Nim-1.2.0/nimsuggest/
Nim-1.2.0/nimsuggest/crashtester.nim
Nim-1.2.0/nimsuggest/nimsuggest.nim
Nim-1.2.0/nimsuggest/nimsuggest.nim.cfg
Nim-1.2.0/nimsuggest/nimsuggest.nimble
Nim-1.2.0/nimsuggest/sexp.nim
Nim-1.2.0/nimsuggest/tester.nim
Nim-1.2.0/nimsuggest/tests/
Nim-1.2.0/nimsuggest/tests/dep_v1.nim
Nim-1.2.0/nimsuggest/tests/dep_v2.nim
Nim-1.2.0/nimsuggest/tests/disabled_ttemplate_highlight.nim
Nim-1.2.0/nimsuggest/tests/taccent_highlight.nim
Nim-1.2.0/nimsuggest/tests/tcallstrlit_highlight.nim
Nim-1.2.0/nimsuggest/tests/tcase.nim
Nim-1.2.0/nimsuggest/tests/tchk1.nim
Nim-1.2.0/nimsuggest/tests/tcon1.nim
Nim-1.2.0/nimsuggest/tests/tcon_variable.nim
Nim-1.2.0/nimsuggest/tests/tcursor_at_end.nim
Nim-1.2.0/nimsuggest/tests/tdef1.nim
Nim-1.2.0/nimsuggest/tests/tdot1.nim
Nim-1.2.0/nimsuggest/tests/tdot2.nim
Nim-1.2.0/nimsuggest/tests/tdot3.nim
Nim-1.2.0/nimsuggest/tests/tdot4.nim
Nim-1.2.0/nimsuggest/tests/tgeneric_highlight.nim
Nim-1.2.0/nimsuggest/tests/tinclude.nim
Nim-1.2.0/nimsuggest/tests/tmacro_highlight.nim
Nim-1.2.0/nimsuggest/tests/tno_deref.nim
Nim-1.2.0/nimsuggest/tests/tobj_highlight.nim
Nim-1.2.0/nimsuggest/tests/tqualified_highlight.nim
Nim-1.2.0/nimsuggest/tests/tsetter_highlight.nim
Nim-1.2.0/nimsuggest/tests/tsi_highlight.nim
Nim-1.2.0/nimsuggest/tests/tstrutils.nim
Nim-1.2.0/nimsuggest/tests/tsug_accquote.nim
Nim-1.2.0/nimsuggest/tests/tsug_regression.nim
Nim-1.2.0/nimsuggest/tests/tsug_template.nim
Nim-1.2.0/nimsuggest/tests/ttype_decl.nim
Nim-1.2.0/nimsuggest/tests/ttype_highlight.nim
Nim-1.2.0/nimsuggest/tests/twithin_macro.nim
Nim-1.2.0/nimsuggest/tests/twithin_macro_prefix.nim

These are used for the nimsuggest binary, but the files can also be used as a library, such as in nimlsp (https://github.com/PMunch/nimlsp). Today nimlsp can't build on arch because those library files are not here.

Note: nimlsp hardcodes those files to be at the root, ie nimsuggest is a sibling to bin. That's probably wrong, and something to improve in nimlsp because we don't want to have a /nimsuggest dir
This task depends upon

Closed by  Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:01 GMT
Reason for closing:  Moved
Additional comments about closing:  https://gitlab.archlinux.org/archlinux/p ackaging/packages/nim/issues/1
Comment by Levente Polyak (anthraxx) - Monday, 20 April 2020, 20:51 GMT
so what precisely are you suggesting now, where should this be packaged to get recognized? putting files outside a FHS is not just wrong, i will not happen :) so wherever those files go, it will not be /nimsuggest ever.
Comment by Matthieu Rakotojaona (rakoo) - Monday, 20 April 2020, 21:02 GMT
Yeah, I'm still new to nim but I don't understand how they could put it at the same level as /bin :) I'd suggest /usr/lib/nim/nimsuggest, and update both nim and nimlsp to follow this standard way of practice. I'll need to discuss with the latter two before we will do something in arch
Comment by Levente Polyak (anthraxx) - Monday, 20 April 2020, 21:30 GMT
I can put the sources in /usr/lib/nim/nimsuggest/ like we do with the other sources, but any further changes required will need to come from upstream.
Comment by Matthieu Rakotojaona (rakoo) - Monday, 20 April 2020, 21:36 GMT
Yeah but that wouldn't be really useful, because no application would go there to search for nimsuggest files, unless patched by Arch, and I don't think that's a reasonable thing to do to diverge too much from upstream.

I've opened a ticket upstream (https://github.com/nim-lang/Nim/issues/14040), let's see what they think of this first
Comment by Buggy McBugFace (bugbot) - Tuesday, 08 August 2023, 19:11 GMT
This is an automated comment as this bug is open for more then 2 years. Please reply if you still experience this bug otherwise this issue will be closed after 1 month.

Loading...