FS#66265 - [dnsmasq] use the systemd unit provided by upstream

Attached to Project: Arch Linux
Opened by nl6720 (nl6720) - Wednesday, 15 April 2020, 14:22 GMT
Last edited by Toolybird (Toolybird) - Wednesday, 27 September 2023, 07:06 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Christian Hesse (eworm)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
dnsmasq provides a "dnsmasq.service" systemd unit in contrib/systemd/ .
Please use the provided unit instead of a custom one. The custom dnsmasq.service lacks some changes from the latest dnsmasq versions that fix unit ordering.
Improvements to dnsmasq.service should be submitted upstream instead of kept only for Arch.

Additional info:
* package version(s)
* config and/or log files etc.
* link to upstream bug report, if any
dnsmasq 2.81-2
http://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=blob;f=contrib/systemd/README;hb=HEAD


Steps to reproduce:
systemctl cat dnsmasq.service
This task depends upon

Closed by  Toolybird (Toolybird)
Wednesday, 27 September 2023, 07:06 GMT
Reason for closing:  Fixed
Additional comments about closing:  Kinda fixed in dnsmasq 2.81-3
Comment by Christian Hesse (eworm) - Wednesday, 15 April 2020, 18:44 GMT
IMHO the upstream unit is in bad shape. It does not even use a dedicated user whereas ours does.
I've been thinking about pushing some changes upstream... Until then - no.
Comment by nl6720 (nl6720) - Friday, 17 April 2020, 08:37 GMT
Well, until then, at least update the packaged unit to have:

After=network.target
Before=network-online.target nss-lookup.target
Wants=nss-lookup.target
Comment by Christian Hesse (eworm) - Friday, 17 April 2020, 19:02 GMT
Sure, makes sense.
Pushed in dnsmasq 2.81-3.
Comment by Buggy McBugFace (bugbot) - Tuesday, 08 August 2023, 19:11 GMT
This is an automated comment as this bug is open for more then 2 years. Please reply if you still experience this bug otherwise this issue will be closed after 1 month.

Loading...