FS#66257 - [netdata] switch to new dashboard

Attached to Project: Community Packages
Opened by hexchain (hexchain) - Tuesday, 14 April 2020, 13:48 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Saturday, 29 January 2022, 05:20 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Sven-Hendrik Haase (Svenstaro)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

Description:
Upstream has introduced a new dashboard and have made it the default one since v1.20.0[1]. It would be good if we can package this dashboard.

Also, upstream has provided a script to switch between these two dashboards. It is currently questionably included in our package and is under /usr/libexec/netdata. Judging from the way it works I don't think it is suitable in our package, but then another way to switch dashboards might be needed, or we might just drop the old one.

[1] https://github.com/netdata/netdata/pull/8363

Additional info:
* package version(s)
netdata v1.21.1
This task depends upon

Closed by  Sven-Hendrik Haase (Svenstaro)
Saturday, 29 January 2022, 05:20 GMT
Reason for closing:  Fixed
Comment by Sven-Hendrik Haase (Svenstaro) - Sunday, 19 April 2020, 08:45 GMT
I'm a little bit confused. It seems to me that the Makefile doesn't actually run the script nor fetches the dashboard in any other way while upstream still ships the "classic" dashboard. I'll have to conclude that the "classic" dashboard is still meant to be the default with the script offering users to manually install the new alternative dashboard.

Could you clarify this with upstream and maybe ask them to officially switch to this dashboard as the default via Makefile if that is actually their intention?
Comment by hexchain (hexchain) - Sunday, 19 April 2020, 09:53 GMT
Looks like they are trying to ditch the switching script and install the old dashboard into a subdirectory, see https://github.com/netdata/netdata/issues/8662.
Comment by Sven-Hendrik Haase (Svenstaro) - Sunday, 19 April 2020, 10:44 GMT
Alright I'll let them figure it out and do something in the package once the dust has settled.
Comment by Ken Swenson (flat) - Tuesday, 07 July 2020, 02:11 GMT
It looks like they have decided how to move forward and essentially use a shell script to download the new dashboard repo.

See https://github.com/netdata/netdata/pull/8752

This is the current bundle script: https://github.com/netdata/netdata/blob/master/packaging/bundle-dashboard.sh

It seems to just download the tarball release, check the checksum from the main repo and then untar and copy the files to the webdir.

Due to the new dashboard not being installed and the old in the normal place this actually breaks some functionality and you would need to use /netdata/old if you are using a subfolder behind a reverse proxy.
Comment by hexchain (hexchain) - Tuesday, 07 July 2020, 09:21 GMT
I haven't followed this for a while, but the last time I checked there was not much point packaging the new dashboard, as the only missing feature seemed to be Netdata Cloud Agent, which is unavailable whatsoever due to some library dependency issues (see https://github.com/netdata/netdata/issues/8961).

Also, see https://github.com/netdata/dashboard/issues/83.
Comment by Ken Swenson (flat) - Tuesday, 07 July 2020, 10:51 GMT
The point for me was the alarms section of the dashboard was completely broken for me unless I used a further subdirectory /old or copied in the new dashboard. While yes the Netdata Cloud Agent does not seem to function everything else does. I copied in the new dashboard and the only issue I've had is a notification that the cloud agent won't run.

You can see here there are a couple other Arch users that had the same issue unaware of this issue that the new dashboard isn't packaged. https://github.com/netdata/netdata/issues/9035

Another option would be to ensure /old is defaulted to somehow. I assume however that packaging the software as intended by upstream would be the better solution. Either way not my decision just wanted to provide some further information. Will likely add the issues and fixes I've encountered to the wiki when I have time.
Comment by Sven-Hendrik Haase (Svenstaro) - Thursday, 26 November 2020, 00:01 GMT
Did anything change in regard to this from upstream?
Comment by hexchain (hexchain) - Thursday, 26 November 2020, 00:32 GMT
Does not seem so. As far as I can see [1] is still true. I'm not sure why they closed it.

A possible fix now would be to build the new dashboard with this package and to remove the old dashboard (except for dashboard_info.js) before copying the new one to the same directory. This also seems to be what their installation[2] script is doing, although they don't seem to remove the old one.

[1] https://github.com/netdata/dashboard/issues/83
[2] https://github.com/netdata/netdata/blob/d5d45793cd69b0169b908ade0c99ef3b39a8fd6e/netdata-installer.sh#L1332
Comment by Sven-Hendrik Haase (Svenstaro) - Friday, 28 January 2022, 02:12 GMT
Is issue still current?
Comment by hexchain (hexchain) - Friday, 28 January 2022, 10:38 GMT
It seems the new dashboard (netdata/dashboard) is now automatically copied into their main repo[1][2].

[1] https://github.com/netdata/netdata/blob/master/web/gui/bundle_dashboard.py
[2] https://github.com/netdata/netdata/commits/master/web/gui/dashboard
Comment by Sven-Hendrik Haase (Svenstaro) - Friday, 28 January 2022, 18:33 GMT
Seems like I can close the issue then?
Comment by hexchain (hexchain) - Saturday, 29 January 2022, 05:11 GMT
Yes, I believe so.

Loading...