FS#66257 - [netdata] switch to new dashboard
Attached to Project:
Community Packages
Opened by hexchain (hexchain) - Tuesday, 14 April 2020, 13:48 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Saturday, 29 January 2022, 05:20 GMT
Opened by hexchain (hexchain) - Tuesday, 14 April 2020, 13:48 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Saturday, 29 January 2022, 05:20 GMT
|
Details
Description:
Upstream has introduced a new dashboard and have made it the default one since v1.20.0[1]. It would be good if we can package this dashboard. Also, upstream has provided a script to switch between these two dashboards. It is currently questionably included in our package and is under /usr/libexec/netdata. Judging from the way it works I don't think it is suitable in our package, but then another way to switch dashboards might be needed, or we might just drop the old one. [1] https://github.com/netdata/netdata/pull/8363 Additional info: * package version(s) netdata v1.21.1 |
This task depends upon
Closed by Sven-Hendrik Haase (Svenstaro)
Saturday, 29 January 2022, 05:20 GMT
Reason for closing: Fixed
Saturday, 29 January 2022, 05:20 GMT
Reason for closing: Fixed
Could you clarify this with upstream and maybe ask them to officially switch to this dashboard as the default via Makefile if that is actually their intention?
See https://github.com/netdata/netdata/pull/8752
This is the current bundle script: https://github.com/netdata/netdata/blob/master/packaging/bundle-dashboard.sh
It seems to just download the tarball release, check the checksum from the main repo and then untar and copy the files to the webdir.
Due to the new dashboard not being installed and the old in the normal place this actually breaks some functionality and you would need to use /netdata/old if you are using a subfolder behind a reverse proxy.
Also, see https://github.com/netdata/dashboard/issues/83.
You can see here there are a couple other Arch users that had the same issue unaware of this issue that the new dashboard isn't packaged. https://github.com/netdata/netdata/issues/9035
Another option would be to ensure /old is defaulted to somehow. I assume however that packaging the software as intended by upstream would be the better solution. Either way not my decision just wanted to provide some further information. Will likely add the issues and fixes I've encountered to the wiki when I have time.
A possible fix now would be to build the new dashboard with this package and to remove the old dashboard (except for dashboard_info.js) before copying the new one to the same directory. This also seems to be what their installation[2] script is doing, although they don't seem to remove the old one.
[1] https://github.com/netdata/dashboard/issues/83
[2] https://github.com/netdata/netdata/blob/d5d45793cd69b0169b908ade0c99ef3b39a8fd6e/netdata-installer.sh#L1332
[1] https://github.com/netdata/netdata/blob/master/web/gui/bundle_dashboard.py
[2] https://github.com/netdata/netdata/commits/master/web/gui/dashboard