FS#66057 - [watchman] watchman-wait 'dict' object has no attribute 'iteritems'

Attached to Project: Community Packages
Opened by Antoine (saveman71) - Wednesday, 01 April 2020, 09:29 GMT
Last edited by Jelle van der Waa (jelly) - Friday, 03 April 2020, 18:55 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Jelle van der Waa (jelly)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

watchman-wait, and derivatives (watchman-make) don't work due to a Python2/3 mismatch/error:


$ watchman-wait .
Traceback (most recent call last):
File "/usr/bin/watchman-wait", line 185, in <module>
for _, sub in subscriptions.iteritems():
AttributeError: 'dict' object has no attribute 'iteritems'



Watchman Version: 4.9.0-3
Python Version: 3.8.2

$ head -2 /usr/bin/watchman-wait
#!/usr/bin/python
from __future__ import print_function


Steps to reproduce: Run `watchman-wait .` anywhere.



It seems it was fixed in https://github.com/facebook/watchman/commit/17958f7d 2 years ago, but somehow this doesn't work on Arch? One user reported a similar  bug 2  years ago, and at least one user is impacted by the same bug as me on Arch in the last 7 days: https://github.com/facebook/watchman/issues/660
This task depends upon

Closed by  Jelle van der Waa (jelly)
Friday, 03 April 2020, 18:55 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in 4.9.0-4
Comment by loqs (loqs) - Wednesday, 01 April 2020, 19:53 GMT
Could you explain the comment it does not work on arch? Did you try applying that commit to 4.9.0?
Comment by Antoine (saveman71) - Friday, 03 April 2020, 08:20 GMT
No, I did not try to apply the commit. I'm saying it doesn't work because that's a 2 years old commit that I thought would be in the latest release but actually it's only in upstream master.

So 17958f7d could be applied to fix at least that bug, as it was done on homebrew: https://github.com/Homebrew/homebrew-core/issues/33227

Anyway i'm not too familiar with watchman's release process but it appears weird, master is waaaay way ahead.

Loading...