FS#66028 - [lutris] make gvfs an optional dependency

Attached to Project: Community Packages
Opened by prettyvanilla (prettyvanilla) - Monday, 30 March 2020, 14:58 GMT
Last edited by Filipe Laíns (FFY00) - Monday, 30 March 2020, 22:12 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Filipe Laíns (FFY00)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

As was requested (https://github.com/lutris/lutris/issues/2514) and implemented (https://github.com/lutris/lutris/commit/061c496efc0d2ad108d8dfecb57746a28e188c14) upstream, gvfs can be listed as an optional dependency.
I uninstalled gvfs locally and tested everything that makes use of it and didn't find any issues. Only Gtk.show_uri supposedly makes use of it and is guarded with a fallback to xdg-open (https://github.com/lutris/lutris/blob/061c496efc0d2ad108d8dfecb57746a28e188c14/lutris/gui/widgets/utils.py#L46), but interestingly while stepping through the code Gtk.show_uri doesn't actually throw an exception on my system without gvfs installed. Not sure how or if current Gtk even makes use of it anymore in show_uri.
This task depends upon

Closed by  Filipe Laíns (FFY00)
Monday, 30 March 2020, 22:12 GMT
Reason for closing:  Fixed
Additional comments about closing:  lutris 0.5.5-2

Loading...