FS#65957 - [riot-desktop] should depend on electron7

Attached to Project: Community Packages
Opened by Paul Melis (paulmelis) - Tuesday, 24 March 2020, 10:20 GMT
Last edited by Bruno Pagani (ArchangeGabriel) - Sunday, 24 May 2020, 21:45 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Bruno Pagani (ArchangeGabriel)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

While trying to debug an issue (see below) with single-sign on in riot-desktop 1.5.12 it appears that the package depends on the electron package, which is currently at version 8. But riot-desktop should actually build against electron version 7, see https://github.com/vector-im/riot-web/blob/6e68c106f724e536b783685411ded2590a2e63f1/package.json#L156. I assume the riot-desktop build actually uses the global electron installation and does not download its own version, but I don't know enough about electron builds to be sure.

Additional info:

* See https://github.com/vector-im/riot-web/issues/12830 for more information.
* This is with riot-desktop 1.5.12
This task depends upon

Closed by  Bruno Pagani (ArchangeGabriel)
Sunday, 24 May 2020, 21:45 GMT
Reason for closing:  Fixed
Additional comments about closing:  Ended up being  FS#66324 .
Comment by Eli Schwartz (eschwartz) - Tuesday, 24 March 2020, 16:49 GMT
Are you stating that the problem from that bug report is caused by the use of electron 8 instead of electron 7?
Comment by Thomas Schuetz (Murray_B) - Wednesday, 25 March 2020, 15:00 GMT
The bug is closed, because it is a duplicate, but there is another problem with electron 8, the system tray icon is gone:
https://bugs.archlinux.org/task/65714

As stated in the bugs, riot itself is distributed with electron 7 again. And I would prefer this for the archlinux package too,
the system tray icon is the reason I am using riot-desktop, without it, the package isn't useful at all, because there is no
real other difference to the browser version.
Comment by Paul Melis (paulmelis) - Friday, 03 April 2020, 11:06 GMT
> Are you stating that the problem from that bug report is caused by the use of electron 8 instead of electron 7?

That isn't clear, although the Riot dev in the linked issue does hint in that direction.
Comment by Steef Hegeman (Steef435) - Friday, 03 April 2020, 22:58 GMT
Just asked upstream, they're going to move to electron 8 for the upcoming 1.6 release. riot-desktop-specific code will be at a separate repository too: https://github.com/vector-im/riot-desktop (gonna see if I can write a PKGBUILD for that, current maintainer seems to have his hands full since it hasn't been updated for a month). So maybe it's not worth the effort to roll back on the current release.
Comment by Bruno Pagani (ArchangeGabriel) - Tuesday, 07 April 2020, 18:26 GMT
Since debugging with upstream and installation of electron7 to use with riot instead did not results in fixing the issue, I’m indeed not going to revert to electron7, especially since upstream will be moving forward shortly to riot 1.6 based on electron 8.x.
Comment by Bruno Pagani (ArchangeGabriel) - Tuesday, 07 April 2020, 18:28 GMT
P.S.: I’ve indeed been very busy lately, but hopefully I should be able to package 1.6 when it comes out.

Loading...