FS#65939 - [python-pdfminer] scripts in /usr/bin/ do not have interpreter line

Attached to Project: Community Packages
Opened by fabbox (fabbox) - Sunday, 22 March 2020, 18:54 GMT
Last edited by Bruno Pagani (ArchangeGabriel) - Wednesday, 27 May 2020, 18:44 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Bruno Pagani (ArchangeGabriel)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
pdf2txt.py and dumppdf.py installed in /usr/bin/ are executable (x) but there is no interpreter line (#!/usr/bin/python or similar) at the beginning of the two files which leads to a wrong behaviour.
I would suggest to add the python interpreter line at the beginning of this two scripts.

I fill the bug here because I think the interpreter line can be distro specific. Do not hesitate to comment if I'm wrong and I will open the bug upstream.

Additional info:
* package version(s): 20200124-1

Steps to reproduce:

run "pdf2txt.py" or "dumppdf.py" from a terminal :

~ % dumppdf.py
/usr/bin/dumppdf.py: line 1: Extract pdf structure in XML format: command not found

extra info:
Note that, on my system, running the script from a terminal leads to export a screenshot of my screen and export it in an pdf at the root of the home folder (named "argparse", "re", "logging") (No the expected behaviour at all).
This task depends upon

Closed by  Bruno Pagani (ArchangeGabriel)
Wednesday, 27 May 2020, 18:44 GMT
Reason for closing:  Fixed
Additional comments about closing:  Upstream 20200517.
Comment by loqs (loqs) - Monday, 23 March 2020, 19:19 GMT
#!/usr/bin/env python was removed from pdf2txt.py by [1] [2] and from duppdf.py by [3] [4].
The commit messages do not explain the removal while commit [5] notes the need for them.

[1] https://github.com/pdfminer/pdfminer.six/commit/bc034c8e59d90e9b2cb8697a1d2fe9a33401761e
[2] https://github.com/pdfminer/pdfminer.six/pull/329/commits/d93a73f87b65837bcbec8ab1b1edc43d681fbc9f
[3] https://github.com/pdfminer/pdfminer.six/commit/6cc78ee1249558fa3a5e0cc8f296ed736460905d
[4] https://github.com/pdfminer/pdfminer.six/pull/321/commits/7aa180d2310f5c87c28ad9cf0f35494c308fe079
[5] https://github.com/pdfminer/pdfminer.six/commit/0fdebc6739143e716a4cb8b7f26ecf012e314cfc
Edit:
changed do to do not
Comment by fabbox (fabbox) - Monday, 23 March 2020, 20:31 GMT
Thanks a lot for this investigation.
So the "fix" could be to remove the executable bit of the two scripts ?
Comment by loqs (loqs) - Monday, 23 March 2020, 20:35 GMT
I would have asked upstream to reinstate the lines as their removal seems unrelated to the intent of commits that removed them and not explained in the commit messages.
Comment by Eli Schwartz (eschwartz) - Tuesday, 24 March 2020, 16:58 GMT
  • Field changed: Category (Packages → Upstream Bugs)
  • Field changed: Severity (Low → Medium)
" The commit messages do explain the removal while commit [5] notes the need for them."

s/do/do not/
?

Comment by loqs (loqs) - Tuesday, 24 March 2020, 18:24 GMT
Yes I meant the commit messages do not explain the removals.
Comment by fabbox (fabbox) - Wednesday, 25 March 2020, 07:49 GMT
reference to upstream bug report: https://github.com/pdfminer/pdfminer.six/issues/405

Loading...