FS#65904 - [fish] pkg-config completionsdir incorrectly set

Attached to Project: Community Packages
Opened by Simon Ser (emersion) - Friday, 20 March 2020, 14:00 GMT
Last edited by Morten Linderud (Foxboron) - Thursday, 31 March 2022, 08:45 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Levente Polyak (anthraxx)
Filipe Laíns (FFY00)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

The fish completionsdir should be set to ${datadir}/fish/vendor_completions.d instead of /usr/local/share/fish/vendor_completions.d. datadir itself should be set to ${prefix}/share to accomodate for non-default prefixes (but maybe that is an upstream bug).

Additional info:
* package version(s) fish 3.1.0-2
* config and/or log files etc.
* link to upstream bug report, if any

Steps to reproduce:

> cat /usr/share/pkgconfig/fish.pc
prefix=/usr
datadir=/usr/share
completionsdir=/usr/local/share/fish/vendor_completions.d
functionsdir=/usr/local/share/fish/vendor_functions.d
confdir=/usr/local/share/fish/vendor_conf.d

Name: fish
Description: fish, the friendly interactive shell
URL: https://fishshell.com/
Version: 3.1.0
This task depends upon

Closed by  Morten Linderud (Foxboron)
Thursday, 31 March 2022, 08:45 GMT
Reason for closing:  Fixed
Additional comments about closing:  3.2.0
Comment by Simon Ser (emersion) - Friday, 20 March 2020, 14:22 GMT
Downstream patch available here: https://github.com/fish-shell/fish-shell/pull/6778

In the meantime, Arch could fix this issue by setting extra_completionsdir, extra_functionsdir and extra_confdir at configure time.
Comment by Simon Ser (emersion) - Saturday, 04 April 2020, 14:52 GMT
Downstream patch has been merged.
Comment by lukpod (lukpod) - Sunday, 27 March 2022, 20:24 GMT
https://github.com/fish-shell/fish-shell/commit/d9d3557fcfbce1fe603623f536242c20e40b599b