FS#65882 - [netdata] crash on exit

Attached to Project: Community Packages
Opened by hexchain (hexchain) - Wednesday, 18 March 2020, 20:54 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Thursday, 26 March 2020, 17:06 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Sven-Hendrik Haase (Svenstaro)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
The current v1.20.0 netdata has a bug that causes it to crash upon exit. An upstream bug report is at [1] and a fix is at [2]. More specifically, the fix is commit cf618e196db70b9aceb13e62a6b1c0df4693a04e (Adhere to the API change of libuv v1.35). It has not been merged upstream, though.

[1] https://github.com/netdata/netdata/issues/8421
[2] https://github.com/netdata/netdata/pull/8425

Steps to reproduce:
1. systemctl stop netdata
2. observe that the process crashed
This task depends upon

Closed by  Sven-Hendrik Haase (Svenstaro)
Thursday, 26 March 2020, 17:06 GMT
Reason for closing:  Upstream
Comment by Sven-Hendrik Haase (Svenstaro) - Thursday, 19 March 2020, 17:56 GMT
I'd prefer not to pull this before it's been upstreamed.
Comment by hexchain (hexchain) - Thursday, 19 March 2020, 18:23 GMT
The bigger problem with this is that it loses recent metrics on exit, which is kind of a hassle.

But I have no objection to waiting for upstream to accept it first.
Comment by Sven-Hendrik Haase (Svenstaro) - Thursday, 19 March 2020, 18:35 GMT
Oh, well that sucks. I'll consider pulling it.
Comment by hexchain (hexchain) - Tuesday, 24 March 2020, 10:05 GMT
The pull request #8425 has been merged.
Comment by Sven-Hendrik Haase (Svenstaro) - Wednesday, 25 March 2020, 11:15 GMT
I'll try to get them to do a release.
Comment by Sven-Hendrik Haase (Svenstaro) - Thursday, 26 March 2020, 17:06 GMT
They'll do a release on April 6th and I can wait for that as I don't have time to backport the patch (which doesn't appear to apply cleanly). Thanks for the report and the upstream fix!

Loading...