FS#65788 - [terminator] URL highlighting broken since vte 0.60

Attached to Project: Community Packages
Opened by Jaume Delclòs Coll (cosarara) - Wednesday, 11 March 2020, 14:53 GMT
Last edited by Giancarlo Razzolini (grazzolini) - Wednesday, 22 April 2020, 18:34 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Giancarlo Razzolini (grazzolini)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

Description:

https://bugs.archlinux.org/task/65772

The URL highlighting feature of terminator breaks after updating vte3 from 0.58.3-1 to 0.60.0-1.
VTE 0.60 removed the implementation for vte_terminal_match_add_gregex, which has been deprecated since VTE 0.46.
https://developer.gnome.org/vte/unstable/VteTerminal.html#vte-terminal-match-add-gregex

Additional info:
* vte 0.60.0-1
* terminator 1.91-6
This issue also affects mate-terminal, lxterminal and tilda.

Steps to reproduce:
* Run terminator
* type https://bugs.archlinux.org and see that it is not highlighted when hovered with the mouse pointer

As a workaround, downgrade vte3 to 0.58.3-1.
This task depends upon

Closed by  Giancarlo Razzolini (grazzolini)
Wednesday, 22 April 2020, 18:34 GMT
Reason for closing:  Fixed
Additional comments about closing:  terminator-1.92-1 fixes this
Comment by Jaume Delclòs Coll (cosarara) - Wednesday, 11 March 2020, 14:54 GMT
Sorry, I forgot to add the summary and now I can't edit. It should read "URL highlighting broken since vte 0.60".
Comment by Giancarlo Razzolini (grazzolini) - Wednesday, 11 March 2020, 16:18 GMT
The project is quite dead and with python2 dropping approaching I'm not even sure terminator is going to remain on the repositories. I have been following a python 3 fork closely: https://github.com/JAugusto42/terminator but it's not quite there yet.
Comment by egmont (egmont) - Monday, 16 March 2020, 17:37 GMT
Not sure what to think about this JAugusto42 guy's attempt, whether to admire or pity it...

There already exists a python3 version of terminator. One or two minor, trivially addressable problems put aside, it's well usable. All he would have needed to do was to check Terminator's upstream bug tracker, or the Debian or Fedora packags to find this work. Instead he started from scratch, not only wasting tons of time, but also causing distributions to diverge, users getting confused by receiving different experiences and messy version numbers, and a headache to whoever will want to merge these at one point.

Also the upstream bugtracker contains a discussion, involving the official (inactive) maintainer as well the ones who did the first python3 port, where the project's current maintainer outlines his conditions to hand over maintenance of the project, including the permission to use the same name, to someone. I am not a lawyer; while it's clear that the license allows one to fork the project, I don't think (and probably the current official maintiner doesn't think either) it's okay to make releases using the same project name.

I have not taken a look at JAugusto42's work, and I'm not planning to. I am not aware of the quality of his work. Without taking this into account, I believe the right thing for any distro is to seriously consider using the first attempt. Unless the creator of the second branch clearly expresses that he was aware of the first one and can bring up strong, valid arguments why he decided not to continue on top of that (which I highly doubt he will be able to do), and that he has permissons from upstream to make releases under the original name, IMHO he can't be taken seriously.

(This was a response to the previous comment, not to the original bug.)
Comment by Giancarlo Razzolini (grazzolini) - Monday, 16 March 2020, 19:04 GMT
@egmont

I have taken a look on the first attempt, and it's not on par yet (not sure if it will be) with python2 version. Having said that, I've never said I was going to switch the Arch package to any specific fork.
Comment by Jose Augusto (jaugusto42) - Wednesday, 18 March 2020, 13:23 GMT
Hi @egmont
First, i do this fork for me, since none of the forks for python3 is being maintained and there is a branch ported to python 3 in the project itself, but it also seems abandoned. As soon as a version of the terminator ported to python 3 enters the official arch repositories, I will start contributing to it, I don't care what version it will be.

Loading...